Changeset 167732 in webkit
- Timestamp:
- Apr 23, 2014 5:32:14 PM (10 years ago)
- Location:
- trunk
- Files:
-
- 1 deleted
- 22 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r167718 r167732 1 2014-04-23 Alexey Proskuryakov <ap@apple.com> 2 3 Eliminate internals.setMockScrollbarsEnabled() 4 https://bugs.webkit.org/show_bug.cgi?id=132085 5 6 Reviewed by Tim Horton. 7 8 Remove calls, all of which were resetting it to true (which is the default, and 9 the only value that makes sense). 10 11 * compositing/geometry/fixed-position.html: 12 * compositing/geometry/horizontal-scroll-composited.html: 13 * compositing/geometry/vertical-scroll-composited.html: 14 * compositing/iframes/resources/scrollgrandchild-inner.html: 15 * compositing/overflow/fixed-position-ancestor-clip.html: 16 * compositing/resources/mock_scrollbars.js: Removed. 17 * css3/filters/blur-filter-page-scroll-parents.html: 18 * css3/filters/blur-filter-page-scroll-self.html: 19 * css3/filters/blur-filter-page-scroll.html: 20 * fast/dom/window-scroll-scaling.html: 21 * fast/events/touch/gesture/gesture-scrollbar.html: 22 * fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: 23 * fast/sub-pixel/transformed-iframe-copy-on-scroll.html: 24 * media/video-controls-rendering.html: 25 * media/video-zoom.html: 26 * scrollingcoordinator/resources/non-fast-scrollable-region-testing.js: 27 1 28 2014-04-23 David Hyatt <hyatt@apple.com> 2 29 -
trunk/LayoutTests/compositing/geometry/fixed-position.html
r100545 r167732 6 6 <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> 7 7 <title>Position fixed</title> 8 <script src="../resources/mock_scrollbars.js"></script>9 8 <style type="text/css" media="screen"> 10 9 body { -
trunk/LayoutTests/compositing/geometry/horizontal-scroll-composited.html
r119992 r167732 6 6 testRunner.waitUntilDone(); 7 7 </script> 8 <script src="../resources/mock_scrollbars.js"></script>9 8 </head> 10 9 <body style="width: 600px"> -
trunk/LayoutTests/compositing/geometry/vertical-scroll-composited.html
r119992 r167732 6 6 testRunner.waitUntilDone(); 7 7 </script> 8 <script src="../resources/mock_scrollbars.js"></script>9 8 </head> 10 9 <body style="height: 600px"> -
trunk/LayoutTests/compositing/iframes/resources/scrollgrandchild-inner.html
r119992 r167732 23 23 </style> 24 24 <script> 25 if (window.internals)26 window.internals.settings.setMockScrollbarsEnabled(true);27 25 if (window.testRunner) { 28 26 testRunner.dumpAsText(true); -
trunk/LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html
r100545 r167732 35 35 }, false); 36 36 </script> 37 <script src="../resources/mock_scrollbars.js"></script>38 37 </head> 39 38 <body> -
trunk/LayoutTests/css3/filters/blur-filter-page-scroll-parents.html
r122130 r167732 13 13 } 14 14 </script> 15 <!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. -->16 <script src="../../compositing/resources/mock_scrollbars.js"></script>17 15 <style> 18 16 body { -
trunk/LayoutTests/css3/filters/blur-filter-page-scroll-self.html
r122130 r167732 13 13 } 14 14 </script> 15 <!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. -->16 <script src="../../compositing/resources/mock_scrollbars.js"></script>17 15 <style> 18 16 body { -
trunk/LayoutTests/css3/filters/blur-filter-page-scroll.html
r121348 r167732 13 13 } 14 14 </script> 15 <!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. -->16 <script src="../../compositing/resources/mock_scrollbars.js"></script>17 15 <style> 18 16 body { -
trunk/LayoutTests/fast/dom/window-scroll-scaling.html
r155265 r167732 4 4 <script> 5 5 description("This test ensures that document content width (height) as reported by scrollWidth (scrollHeight) is invariant to changes in page scale factor."); 6 7 if (window.internals)8 window.internals.settings.setMockScrollbarsEnabled(true);9 6 10 7 var body = document.body; -
trunk/LayoutTests/fast/events/touch/gesture/gesture-scrollbar.html
r155267 r167732 65 65 function runTest() 66 66 { 67 internals.settings.setMockScrollbarsEnabled(true);68 67 if (window.eventSender) { 69 68 description('This tests scroll gesture events on a scroll bar. ' + -
trunk/LayoutTests/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html
r137945 r167732 13 13 <script src="../repaint/resources/repaint.js" type="text/javascript"></script> 14 14 <script> 15 if (window.testRunner) {15 if (window.testRunner) 16 16 testRunner.waitUntilDone(); 17 internals.settings.setMockScrollbarsEnabled(true);18 }19 17 20 18 function setupIframes() { -
trunk/LayoutTests/fast/sub-pixel/transformed-iframe-copy-on-scroll.html
r137945 r167732 19 19 <script src="../repaint/resources/repaint.js" type="text/javascript"></script> 20 20 <script> 21 if (window.testRunner) {21 if (window.testRunner) 22 22 testRunner.waitUntilDone(); 23 internals.settings.setMockScrollbarsEnabled(true);24 }25 23 26 24 function setupIframes() { -
trunk/LayoutTests/media/video-controls-rendering.html
r107740 r167732 13 13 </div> 14 14 <script> 15 if (window.internals)16 window.internals.settings.setMockScrollbarsEnabled(true);17 15 init(); 18 16 setSrcByTagName('video', findMediaFile('video', 'content/test')); -
trunk/LayoutTests/media/video-zoom.html
r120416 r167732 4 4 <script src=media-file.js></script> 5 5 <script> 6 if (window.internals)7 window.internals.settings.setMockScrollbarsEnabled(true);8 9 6 function init() 10 7 { -
trunk/LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js
r158113 r167732 1 1 function runNonFastScrollableRegionTest(scale) { 2 2 var invScale; 3 window.internals.settings.setMockScrollbarsEnabled(true);4 3 if (scale != undefined) { 5 4 window.internals.setPageScaleFactor(scale, 0, 0); -
trunk/Source/WebCore/ChangeLog
r167730 r167732 1 2014-04-23 Alexey Proskuryakov <ap@apple.com> 2 3 Eliminate internals.setMockScrollbarsEnabled() 4 https://bugs.webkit.org/show_bug.cgi?id=132085 5 6 Reviewed by Tim Horton. 7 8 This was essentially unused, and also didnt work. 9 10 * testing/InternalSettings.cpp: 11 (WebCore::InternalSettings::Backup::restoreTo): 12 (WebCore::InternalSettings::setMockScrollbarsEnabled): Deleted. 13 * testing/InternalSettings.h: 14 * testing/InternalSettings.idl: 15 1 16 2014-04-23 Anders Carlsson <andersca@apple.com> 2 17 -
trunk/Source/WebCore/testing/InternalSettings.cpp
r166459 r167732 136 136 settings.setMediaTypeOverride(m_originalMediaTypeOverride); 137 137 settings.setCanvasUsesAcceleratedDrawing(m_originalCanvasUsesAcceleratedDrawing); 138 settings.setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);139 138 RuntimeEnabledFeatures::sharedFeatures().setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled); 140 139 settings.setImagesEnabled(m_imagesEnabled); … … 211 210 } 212 211 213 void InternalSettings::setMockScrollbarsEnabled(bool enabled, ExceptionCode& ec)214 {215 InternalSettingsGuardForSettings();216 settings()->setMockScrollbarsEnabled(enabled);217 }218 219 212 void InternalSettings::setTouchEventEmulationEnabled(bool enabled, ExceptionCode& ec) 220 213 { -
trunk/Source/WebCore/testing/InternalSettings.h
r166459 r167732 101 101 void resetToConsistentState(); 102 102 103 void setMockScrollbarsEnabled(bool enabled, ExceptionCode&);104 103 void setUsesOverlayScrollbars(bool enabled, ExceptionCode&); 105 104 void setTouchEventEmulationEnabled(bool enabled, ExceptionCode&); -
trunk/Source/WebCore/testing/InternalSettings.idl
r166459 r167732 28 28 JSGenerateToJSObject 29 29 ] interface InternalSettings : InternalSettingsGenerated { 30 [RaisesException] void setMockScrollbarsEnabled(boolean enabled);31 30 [RaisesException] void setTouchEventEmulationEnabled(boolean enabled); 32 31 [RaisesException] void setStandardFontFamily(DOMString family, DOMString script); -
trunk/Tools/ChangeLog
r167731 r167732 1 2014-04-23 Alexey Proskuryakov <ap@apple.com> 2 3 Eliminate internals.setMockScrollbarsEnabled() 4 https://bugs.webkit.org/show_bug.cgi?id=132085 5 6 Reviewed by Tim Horton. 7 8 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): 9 No need to reset the preference, there is no way it can change. 10 1 11 2014-04-23 James Craig <jcraig@apple.com> 2 12 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r167728 r167732 882 882 [preferences setUsePreHTML5ParserQuirks:NO]; 883 883 [preferences setAsynchronousSpellCheckingEnabled:NO]; 884 [preferences setMockScrollbarsEnabled:YES];884 ASSERT([preferences mockScrollbarsEnabled]); 885 885 886 886 #if ENABLE(WEB_AUDIO)
Note: See TracChangeset
for help on using the changeset viewer.