Changeset 167742 in webkit


Ignore:
Timestamp:
Apr 23, 2014 8:56:09 PM (10 years ago)
Author:
akling@apple.com
Message:

Remove unused WKPageSetMemoryCacheClientCallsEnabled API.
<​https://webkit.org/b/132098>

This API was added to WK2 back in 2011 but never actually used.

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetMemoryCacheClientCallsEnabled): Deleted.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMemoryCacheMessagesEnabled): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
Location:
trunk/Source/WebKit2
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r167740 r167742  
     12014-04-23  Andreas Kling  <akling@apple.com>
     2
     3        Remove unused WKPageSetMemoryCacheClientCallsEnabled API.
     4        <https://webkit.org/b/132098>
     5
     6        This API was added to WK2 back in 2011 but never actually used.
     7
     8        Reviewed by Anders Carlsson.
     9
     10        * Shared/WebPageCreationParameters.cpp:
     11        (WebKit::WebPageCreationParameters::encode):
     12        (WebKit::WebPageCreationParameters::decode):
     13        * Shared/WebPageCreationParameters.h:
     14        * UIProcess/API/C/WKPage.cpp:
     15        (WKPageSetMemoryCacheClientCallsEnabled): Deleted.
     16        * UIProcess/API/C/WKPage.h:
     17        * UIProcess/WebPageProxy.cpp:
     18        (WebKit::WebPageProxy::WebPageProxy):
     19        (WebKit::WebPageProxy::creationParameters):
     20        (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Deleted.
     21        * UIProcess/WebPageProxy.h:
     22        * WebProcess/WebPage/WebPage.cpp:
     23        (WebKit::WebPage::WebPage):
     24        (WebKit::WebPage::setMemoryCacheMessagesEnabled): Deleted.
     25        * WebProcess/WebPage/WebPage.h:
     26        * WebProcess/WebPage/WebPage.messages.in:
     27
    1282014-04-23  Simon Fraser  <simon.fraser@apple.com>
    229

  • trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp

    r167481 r167742  
    4242    encoder << drawsTransparentBackground;
    4343    encoder << underlayColor;
    44     encoder << areMemoryCacheClientCallsEnabled;
    4544    encoder << useFixedLayout;
    4645    encoder << fixedLayoutSize;
    … …  
    9594        return false;
    9695    if (!decoder.decode(parameters.underlayColor))
    97         return false;
    98     if (!decoder.decode(parameters.areMemoryCacheClientCallsEnabled))
    9996        return false;
    10097    if (!decoder.decode(parameters.useFixedLayout))

  • trunk/Source/WebKit2/Shared/WebPageCreationParameters.h

    r167481 r167742  
    7070    WebCore::Color underlayColor;
    7171
    72     bool areMemoryCacheClientCallsEnabled;
    73 
    7472    bool useFixedLayout;
    7573    WebCore::IntSize fixedLayoutSize;

  • trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp

    r167519 r167742  
    296296}
    297297
    298 void WKPageSetMemoryCacheClientCallsEnabled(WKPageRef pageRef, bool memoryCacheClientCallsEnabled)
    299 {
    300     toImpl(pageRef)->setMemoryCacheClientCallsEnabled(memoryCacheClientCallsEnabled);
    301 }
    302 
    303298WKStringRef WKPageCopyUserAgent(WKPageRef pageRef)
    304299{

  • trunk/Source/WebKit2/UIProcess/API/C/WKPage.h

    r167172 r167742  
    109109WK_EXPORT uint64_t WKPageGetRenderTreeSize(WKPageRef page);
    110110
    111 WK_EXPORT void WKPageSetMemoryCacheClientCallsEnabled(WKPageRef page, bool memoryCacheClientCallsEnabled);
    112 
    113111WK_EXPORT WKInspectorRef WKPageGetInspector(WKPageRef page);
    114112

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r167698 r167742  
    284284    , m_drawsBackground(true)
    285285    , m_drawsTransparentBackground(false)
    286     , m_areMemoryCacheClientCallsEnabled(true)
    287286    , m_useFixedLayout(false)
    288287    , m_suppressScrollbarAnimations(false)
    … …  
    20332032}
    20342033
    2035 void WebPageProxy::setMemoryCacheClientCallsEnabled(bool memoryCacheClientCallsEnabled)
    2036 {
    2037     if (!isValid())
    2038         return;
    2039 
    2040     if (m_areMemoryCacheClientCallsEnabled == memoryCacheClientCallsEnabled)
    2041         return;
    2042 
    2043     m_areMemoryCacheClientCallsEnabled = memoryCacheClientCallsEnabled;
    2044     m_process->send(Messages::WebPage::SetMemoryCacheMessagesEnabled(memoryCacheClientCallsEnabled), m_pageID);
    2045 }
    2046 
    20472034void WebPageProxy::findStringMatches(const String& string, FindOptions options, unsigned maxMatchCount)
    20482035{
    … …  
    42294216    parameters.drawsTransparentBackground = m_drawsTransparentBackground;
    42304217    parameters.underlayColor = m_underlayColor;
    4231     parameters.areMemoryCacheClientCallsEnabled = m_areMemoryCacheClientCallsEnabled;
    42324218    parameters.useFixedLayout = m_useFixedLayout;
    42334219    parameters.fixedLayoutSize = m_fixedLayoutSize;

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.h

    r167735 r167742  
    812812    void pageZoomFactorDidChange(double);
    813813
    814     void setMemoryCacheClientCallsEnabled(bool);
    815 
    816814    // Find.
    817815    void findString(const String&, FindOptions, unsigned maxMatchCount);
    … …  
    15221520    WebCore::Color m_pageExtendedBackgroundColor;
    15231521
    1524     bool m_areMemoryCacheClientCallsEnabled;
    1525 
    15261522    bool m_useFixedLayout;
    15271523    WebCore::IntSize m_fixedLayoutSize;

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r167738 r167742  
    391391    setGapBetweenPages(parameters.gapBetweenPages);
    392392
    393     setMemoryCacheMessagesEnabled(parameters.areMemoryCacheClientCallsEnabled);
    394 
    395393    // If the page is created off-screen, its visibilityState should be prerender.
    396394    m_page->setViewState(m_viewState);
    … …  
    37323730}
    37333731
    3734 void WebPage::setMemoryCacheMessagesEnabled(bool memoryCacheMessagesEnabled)
    3735 {
    3736     m_page->setMemoryCacheClientCallsEnabled(memoryCacheMessagesEnabled);
    3737 }
    3738 
    37393732bool WebPage::canHandleRequest(const WebCore::ResourceRequest& request)
    37403733{

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h

    r167738 r167742  
    669669    float deviceScaleFactor() const;
    670670
    671     void setMemoryCacheMessagesEnabled(bool);
    672 
    673671    void forceRepaintWithoutCallback();
    674672

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in

    r167735 r167742  
    272272    SetMayStartMediaWhenInWindow(bool mayStartMedia)
    273273
    274     SetMemoryCacheMessagesEnabled(bool memoryCacheMessagesEnabled)
    275 
    276274    // FIXME: This a dummy message, to avoid breaking the build for platforms that don't require
    277275    // any synchronous messages, and should be removed when <rdar://problem/8775115> is fixed.
Note: See TracChangeset for help on using the changeset viewer.