Changeset 167770 in webkit
- Timestamp:
- Apr 24, 2014 1:24:13 PM (10 years ago)
- Location:
- trunk/Source/WebKit/mac
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/mac/ChangeLog
r167768 r167770 1 2014-04-24 Ryosuke Niwa <rniwa@webkit.org> 2 3 Text caret disappears in Mail after returning from another application 4 https://bugs.webkit.org/show_bug.cgi?id=132111 5 6 Reviewed by Darin Adler. 7 8 The bug was caused by our SPI _windowChangedKeyState not getting called upon deminiaturization. 9 10 Fixed the bug by using the standard NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification 11 notifications as done in WebKit2 since they DO get called upon deminiaturization. 12 13 * WebView/WebView.mm: 14 (-[WebView addWindowObserversForWindow:]): 15 (-[WebView removeWindowObservers]): 16 (-[WebView _windowKeyStateChanged:]): 17 (-[WebView _windowChangedKeyState]): Deleted. 18 1 19 2014-04-24 Myles C. Maxfield <mmaxfield@apple.com> 2 20 -
trunk/Source/WebKit/mac/WebView/WebView.mm
r167768 r167770 292 292 - (void)_autoscrollForDraggingInfo:(id)dragInfo timeDelta:(NSTimeInterval)repeatDelta; 293 293 - (BOOL)_shouldAutoscrollForDraggingInfo:(id)dragInfo; 294 - (void)_windowChangedKeyState;295 294 @end 296 295 … … 5228 5227 { 5229 5228 if (window) { 5229 [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(windowKeyStateChanged:) 5230 name:NSWindowDidBecomeKeyNotification object:window]; 5231 [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(windowKeyStateChanged:) 5232 name:NSWindowDidResignKeyNotification object:window]; 5230 5233 [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_windowWillOrderOnScreen:) 5231 5234 name:WKWindowWillOrderOnScreenNotification() object:window]; … … 5252 5255 if (window) { 5253 5256 [[NSNotificationCenter defaultCenter] removeObserver:self 5257 name:NSWindowDidBecomeKeyNotification object:window]; 5258 [[NSNotificationCenter defaultCenter] removeObserver:self 5259 name:NSWindowDidResignKeyNotification object:window]; 5260 [[NSNotificationCenter defaultCenter] removeObserver:self 5254 5261 name:WKWindowWillOrderOnScreenNotification() object:window]; 5255 5262 [[NSNotificationCenter defaultCenter] removeObserver:self … … 5338 5345 } 5339 5346 5340 - (void) _windowChangedKeyState5347 - (void)windowKeyStateChanged:(NSNotification *)notification 5341 5348 { 5342 5349 [self _updateActiveState]; 5343 5344 [super _windowChangedKeyState];5345 5350 } 5346 5351
Note: See TracChangeset
for help on using the changeset viewer.