Changeset 167993 in webkit

Timestamp:

Apr 30, 2014 1:54:39 AM (10 years ago)

Author:

Manuel Rego Casasnovas

Message:

[CSS Grid Layout] Enable runtime feature by default
​https://bugs.webkit.org/show_bug.cgi?id=132189

Reviewed by Benjamin Poulain.

Source/WebCore:

• page/Settings.in: Set cssGridLayoutEnabled to true.

Source/WebKit/mac:

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Remove unneeded changes that
enable/disable the runtime feature depending on the compilation flag.
And set it to true by default.

Source/WebKit2:

• Shared/WebPreferencesStore.h: Remove unneeded changes that

enable/disable the runtime feature depending on the compilation flag.
And set it to true by default.

• UIProcess/gtk/ExperimentalFeatures.cpp: Set it to true by default.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Settings.in (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebPreferences.mm (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/WebPreferencesStore.h (modified) (2 diffs)
• WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Grid Layout] Enable runtime feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=132189
+
+        Reviewed by Benjamin Poulain.
+
+        * page/Settings.in: Set cssGridLayoutEnabled to true.
+
 2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/page/Settings.in

@@ -86 +86 @@
 acceleratedFiltersEnabled initial=false
 regionBasedColumnsEnabled initial=false
-cssGridLayoutEnabled initial=false
+cssGridLayoutEnabled initial=true
 useLegacyTextAlignPositionedElementBehavior initial=false
 

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Grid Layout] Enable runtime feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=132189
+
+        Reviewed by Benjamin Poulain.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]): Remove unneeded changes that
+        enable/disable the runtime feature depending on the compilation flag.
+        And set it to true by default.
+
 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebPreferences.mm

@@ -483 +483 @@
         [NSNumber numberWithBool:YES], WebKitCSSRegionsEnabledPreferenceKey,
         [NSNumber numberWithBool:YES], WebKitCSSCompositingEnabledPreferenceKey,
-#if ENABLE(CSS_GRID_LAYOUT)
         [NSNumber numberWithBool:YES],  WebKitCSSGridLayoutEnabledPreferenceKey,
-#else
-        [NSNumber numberWithBool:NO],  WebKitCSSGridLayoutEnabledPreferenceKey,
-#endif
 #if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
         [NSNumber numberWithBool:YES],  WebKitAcceleratedDrawingEnabledPreferenceKey,

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Grid Layout] Enable runtime feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=132189
+
+        Reviewed by Benjamin Poulain.
+
+        * Shared/WebPreferencesStore.h: Remove unneeded changes that
+        enable/disable the runtime feature depending on the compilation flag.
+        And set it to true by default.
+        * UIProcess/gtk/ExperimentalFeatures.cpp: Set it to true by default.
+
 2014-04-30  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesStore.h

@@ -99 +99 @@
 #else
 #define DEFAULT_CANVAS_USES_ACCELERATED_DRAWING true
-#endif
-
-#if ENABLE(CSS_GRID_LAYOUT)
-#define DEFAULT_CSS_GRID_LAYOUT_ENABLED true
-#else
-#define DEFAULT_CSS_GRID_LAYOUT_ENABLED false
 #endif
 
@@ -140 +134 @@
     macro(CSSRegionsEnabled, cssRegionsEnabled, Bool, bool, true) \
     macro(CSSCompositingEnabled, cssCompositingEnabled, Bool, bool, true) \
-    macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, DEFAULT_CSS_GRID_LAYOUT_ENABLED) \
+    macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true) \
     macro(RegionBasedColumnsEnabled, regionBasedColumnsEnabled, Bool, bool, false) \
     macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false) \

trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp

@@ -40 +40 @@
 
 static Setting settings[] = {
-    { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", false },
+    { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", true },
     { ExperimentalFeatures::RegionBasedColumns, "REGION_BASED_COLUMNS", false }
 };