Changeset 168049 in webkit

Timestamp:

Apr 30, 2014 3:05:15 PM (10 years ago)

Author:

Beth Dakin

Message:

Always-visible scrollbars continuously repaint after non-momentum scrollling
​https://bugs.webkit.org/show_bug.cgi?id=132403
-and corresponding-
<rdar://problem/16553878>

Reviewed by Simon Fraser.

No longer universally opt into presentation value mode whenever the scroll
position changes on the scrolling thread. We really only want it for momentum
scrolls, and this will ensure that we always set it to NO once we have set it to
YES.

• page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Expose shouldUsePresentationValue.

• platform/mac/NSScrollerImpDetails.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm (modified) (3 diffs)
• platform/mac/NSScrollerImpDetails.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-30  Beth Dakin  <bdakin@apple.com>
+
+        Always-visible scrollbars continuously repaint after non-momentum scrollling
+        https://bugs.webkit.org/show_bug.cgi?id=132403
+        -and corresponding-
+        <rdar://problem/16553878>
+
+        Reviewed by Simon Fraser.
+
+        No longer universally opt into presentation value mode whenever the scroll 
+        position changes on the scrolling thread. We really only want it for momentum 
+        scrolls, and this will ensure that we always set it to NO once we have set it to 
+        YES.
+        * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
+        (WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
+        (WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
+
+        Expose shouldUsePresentationValue.
+        * platform/mac/NSScrollerImpDetails.h:
+
 2014-04-30  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm

@@ -137 +137 @@
         return;
 
+    if (wheelEvent.momentumPhase() == PlatformWheelEventPhaseBegan) {
+        [m_verticalScrollbarPainter setUsePresentationValue:YES];
+        [m_horizontalScrollbarPainter setUsePresentationValue:YES];
+    }
     if (wheelEvent.momentumPhase() == PlatformWheelEventPhaseEnded || wheelEvent.momentumPhase() == PlatformWheelEventPhaseCancelled) {
-        // If the wheel event is ending or cancelled, then we can tell the ScrollbarPainter API that we won't
-        // be updating the position from our scrolling thread anymore for the time being.
-        if (m_verticalScrollbarPainter)
-            [m_verticalScrollbarPainter setUsePresentationValue:NO];
-        if (m_horizontalScrollbarPainter)
-            [m_horizontalScrollbarPainter setUsePresentationValue:NO];
+        [m_verticalScrollbarPainter setUsePresentationValue:NO];
+        [m_horizontalScrollbarPainter setUsePresentationValue:NO];
     }
 
@@ -372 +372 @@
         [CATransaction lock];
 
-        if (m_verticalScrollbarPainter) {
-            [m_verticalScrollbarPainter setUsePresentationValue:YES];
+        if ([m_verticalScrollbarPainter shouldUsePresentationValue]) {
             float presentationValue;
             float overhangAmount;
@@ -380 +379 @@
         }
 
-        if (m_horizontalScrollbarPainter) {
-            [m_horizontalScrollbarPainter setUsePresentationValue:YES];
+        if ([m_horizontalScrollbarPainter shouldUsePresentationValue]) {
             float presentationValue;
             float overhangAmount;

trunk/Source/WebCore/platform/mac/NSScrollerImpDetails.h

@@ -41 +41 @@
 - (void)setDoubleValue:(double)doubleValue;
 - (void)setPresentationValue:(double)presentationValue;
+- (BOOL)shouldUsePresentationValue;
 - (void)setUsePresentationValue:(BOOL)usePresentationValue;
 - (void)setKnobProportion:(CGFloat)proportion;