Changeset 168174 in webkit

Timestamp:

May 2, 2014, 10:29:20 AM (12 years ago)

Author:

Simon Fraser

Message:

[iOS WK2] Can't scroll on gatesnotes.com
​https://bugs.webkit.org/show_bug.cgi?id=132459
<rdar://problem/16770909>

Reviewed by Benjamin Poulain.

The custom UIView hit-testing code was finding views that were created by
the compositing code for clipping, above the UIScrollViews. We only ever
need to find UIScrollViews here for touch overflow-scrolling, so constrain
the hit-testing code to only return UIScrollViews.

• UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(-[UIView _recursiveFindDescendantScrollViewAtPoint:withEvent:]):
(-[UIView _findDescendantViewAtPoint:withEvent:]):
(-[UIView _recursiveFindDescendantViewAtPoint:withEvent:]): Deleted.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/RemoteLayerTreeHostIOS.mm (modified) (4 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-05-01  Simon Fraser  <simon.fraser@apple.com>
+
+        [iOS WK2] Can't scroll on gatesnotes.com 
+        https://bugs.webkit.org/show_bug.cgi?id=132459
+        <rdar://problem/16770909>
+
+        Reviewed by Benjamin Poulain.
+        
+        The custom UIView hit-testing code was finding views that were created by
+        the compositing code for clipping, above the UIScrollViews. We only ever
+        need to find UIScrollViews here for touch overflow-scrolling, so constrain
+        the hit-testing code to only return UIScrollViews.
+
+        * UIProcess/ios/RemoteLayerTreeHostIOS.mm:
+        (-[UIView _recursiveFindDescendantScrollViewAtPoint:withEvent:]):
+        (-[UIView _findDescendantViewAtPoint:withEvent:]):
+        (-[UIView _recursiveFindDescendantViewAtPoint:withEvent:]): Deleted.
+
 2014-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm

@@ -50 +50 @@
 // UIView hit testing assumes that views should only hit test subviews that are entirely contained
 // in the view. This is not true of web content.
-- (UIView *)_recursiveFindDescendantViewAtPoint:(CGPoint)point withEvent:(UIEvent *)event
+// We only want to find UIScrollViews here. Other views are ignored.
+- (UIView *)_recursiveFindDescendantScrollViewAtPoint:(CGPoint)point withEvent:(UIEvent *)event
 {
     if (self.clipsToBounds && ![self pointInside:point withEvent:event])
@@ -59 +60 @@
         CGPoint subviewPoint = [view convertPoint:point fromView:self];
 
-        if ([view pointInside:subviewPoint withEvent:event])
+        if ([view pointInside:subviewPoint withEvent:event] && [view isKindOfClass:[UIScrollView class]])
             foundView = view;
 
@@ -65 +66 @@
             return;
 
-        if (UIView *hitView = [view _recursiveFindDescendantViewAtPoint:subviewPoint withEvent:event])
+        if (UIView *hitView = [view _recursiveFindDescendantScrollViewAtPoint:subviewPoint withEvent:event])
             foundView = hitView;
     }];
@@ -74 +75 @@
 - (UIView *)_findDescendantViewAtPoint:(CGPoint)point withEvent:(UIEvent *)event
 {
-    return [self _recursiveFindDescendantViewAtPoint:point withEvent:event];
+    return [self _recursiveFindDescendantScrollViewAtPoint:point withEvent:event];
 }