Changeset 168513 in webkit


Ignore:
Timestamp:
May 8, 2014 6:08:30 PM (10 years ago)
Author:
Simon Fraser
Message:

[iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
​https://bugs.webkit.org/show_bug.cgi?id=132719
<rdar://problem/16860837>

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a couple of functions, and sort.

  • WebCore.exp.in:

Source/WebKit2:

If we haven't received visible rects from the web process, compute the
fixed position rect, but only after scale has been set.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r168512 r168513  
     12014-05-08  Simon Fraser  <simon.fraser@apple.com>
     2
     3        [iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
     4        https://bugs.webkit.org/show_bug.cgi?id=132719
     5        <rdar://problem/16860837>
     6
     7        Reviewed by Benjamin Poulain.
     8
     9        Add a couple of functions, and sort.
     10
     11        * WebCore.exp.in:
     12
    1132014-05-08  Jer Noble  <jer.noble@apple.com>
    214

  • trunk/Source/WebCore/WebCore.exp.in

    r168478 r168513  
    718718__ZN7WebCore16createFullMarkupERKNS_5RangeE
    719719__ZN7WebCore16enclosingIntRectERK6CGRect
     720__ZN7WebCore16enclosingIntRectERKNS_10LayoutRectE
    720721__ZN7WebCore16enclosingIntRectERKNS_9FloatRectE
    721722__ZN7WebCore16isEndOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE
    … …  
    22982299_wkDrawBezeledTextFieldCell
    22992300_wkDrawCapsLockIndicator
     2301_wkDrawCellFocusRingWithFrameAtTime
    23002302_wkDrawFocusRing
    23012303_wkDrawFocusRingAtTime
    2302 _wkDrawCellFocusRingWithFrameAtTime
    23032304_wkDrawMediaSliderTrack
    23042305_wkDrawMediaUIPart
    … …  
    27172718__ZNK7WebCore9FloatSizecv6CGSizeEv
    27182719__ZNK7WebCore9FrameView17wasScrolledByUserEv
     2720__ZNK7WebCore9FrameView30viewportConstrainedObjectsRectEv
    27192721__ZNK7WebCore9RenderBox11borderRadiiEv
    27202722_webThreadShouldYield

  • trunk/Source/WebKit2/ChangeLog

    r168512 r168513  
     12014-05-08  Simon Fraser  <simon.fraser@apple.com>
     2
     3        [iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
     4        https://bugs.webkit.org/show_bug.cgi?id=132719
     5        <rdar://problem/16860837>
     6
     7        Reviewed by Benjamin Poulain.
     8       
     9        If we haven't received visible rects from the web process, compute the
     10        fixed position rect, but only after scale has been set.
     11
     12        * WebProcess/WebPage/ios/WebPageIOS.mm:
     13        (WebKit::WebPage::viewportConfigurationChanged):
     14
    1152014-05-08  Jer Noble  <jer.noble@apple.com>
    216

  • trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

    r168473 r168513  
    20882088    }
    20892089    scalePage(scale, scrollPosition);
     2090   
     2091    if (!m_hasReceivedVisibleContentRectsAfterDidCommitLoad) {
     2092        // This takes scale into account, so do after the scale change.
     2093        frameView.setCustomFixedPositionLayoutRect(enclosingIntRect(frameView.viewportConstrainedObjectsRect()));
     2094    }
    20902095}
    20912096
Note: See TracChangeset for help on using the changeset viewer.