Changeset 168562 in webkit

Timestamp:

May 9, 2014 6:10:06 PM (10 years ago)

Author:

Simon Fraser

Message:

Fix some issues with scrolling tree logging
​https://bugs.webkit.org/show_bug.cgi?id=132762

Reviewed by Tim Horton.

Only dump viewport constraints when they change, and dump the primary layer on
scrolling nodes.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingTreeTextStream::dump): Dump the primary layer.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-05-09  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix some issues with scrolling tree logging
+        https://bugs.webkit.org/show_bug.cgi?id=132762
+
+        Reviewed by Tim Horton.
+        
+        Only dump viewport constraints when they change, and dump the primary layer on
+        scrolling nodes.
+        
+        * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
+        (WebKit::RemoteScrollingTreeTextStream::dump): Dump the primary layer.
+
 2014-05-09  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp

@@ -464 +464 @@
     dumpProperty(ts, "type", node.nodeType());
 
+    if (!changedPropertiesOnly || node.hasChangedProperty(ScrollingStateNode::ScrollLayer))
+        dumpProperty(ts, "layer", static_cast<GraphicsLayer::PlatformLayerID>(node.layer()));
+    
     switch (node.nodeType()) {
     case FrameScrollingNode:
@@ -537 +540 @@
     RemoteScrollingTreeTextStream& ts = *this;
 
-    ts << node.viewportConstraints();
+    if (!changedPropertiesOnly || node.hasChangedProperty(ScrollingStateFixedNode::ViewportConstraints))
+        ts << node.viewportConstraints();
 }
 
@@ -544 +548 @@
     RemoteScrollingTreeTextStream& ts = *this;
 
-    ts << node.viewportConstraints();
+    if (!changedPropertiesOnly || node.hasChangedProperty(ScrollingStateFixedNode::ViewportConstraints))
+        ts << node.viewportConstraints();
 }