Changeset 168966 in webkit


Ignore:
Timestamp:
May 16, 2014 4:56:14 AM (10 years ago)
Author:
berto@igalia.com
Message:

RTCDtmfSender default values need to be updated.
​https://bugs.webkit.org/show_bug.cgi?id=132952

Patch by Kiran <​kiran.guduru@samsung.com> on 2014-05-16
Reviewed by Eric Carlson.

Source/WebCore:
The default ToneDuration and ToneGap values are modified in the updated spec.
So these values need to be updated.

Test: fast/mediastream/RTCPeerConnection-dtmf.html.

  • Modules/mediastream/RTCDTMFSender.cpp:

LayoutTests:
Added checks to test default, min value interToneGap
and duration and max value for duration.
(Spec does not specify any max value for inTertoneGap)

  • fast/mediastream/RTCPeerConnection-dtmf.html:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r168921 r168966  
     12014-05-16  Kiran  <kiran.guduru@samsung.com>
     2
     3        RTCDtmfSender default values need to be updated.
     4        https://bugs.webkit.org/show_bug.cgi?id=132952
     5
     6        Reviewed by Eric Carlson.
     7
     8        Added checks to test default, min value interToneGap
     9        and duration and max value for duration.
     10        (Spec does not specify any max value for inTertoneGap)
     11
     12        * fast/mediastream/RTCPeerConnection-dtmf.html:
     13
    1142014-05-15  Daniel Bates  <dabates@apple.com>
    215

  • trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html

    r164602 r168966  
    1717            }
    1818
    19             var firstCall = true;
     19            var lastCall = false;
     20            var callCount = 1;
    2021
    2122            function ontonechange(e) {
    2223                testPassed("ontonechange was called.");
    2324                event = e;
    24                 if (firstCall) {
     25                if (!lastCall) {
    2526                    shouldBeEqualToString('event.tone', "1");
    26                     firstCall = false;
     27                    callCount++;
     28                    if (3 == callCount)
     29                        lastCall = true;
    2730                } else {
    2831                    shouldBeEqualToString('event.tone', "");
    … …  
    4447                    dtmfsender.insertDTMF("1");
    4548                    shouldBeEqualToString('dtmfsender.toneBuffer', "1");
     49                    shouldBeEqualToString('dtmfsender.duration', "100");
     50                    shouldBeEqualToString('dtmfsender.interToneGap', "70");
     51
     52                    dtmfsender.insertDTMF("1", "40", "30");
     53                    shouldBeEqualToString('dtmfsender.toneBuffer', "1");
     54                    shouldBeEqualToString('dtmfsender.duration', "40");
     55                    shouldBeEqualToString('dtmfsender.interToneGap', "30");
     56
     57                    dtmfsender.insertDTMF("1", "6000");
     58                    shouldBeEqualToString('dtmfsender.toneBuffer', "1");
     59                    shouldBeEqualToString('dtmfsender.duration', "6000");
     60                    shouldBeEqualToString('dtmfsender.interToneGap', "70");
     61
     62                    shouldThrow('dtmfsender.insertDTMF("1", "20");');
     63                    shouldThrow('dtmfsender.insertDTMF("1", "7000");');
     64                    shouldThrow('dtmfsender.insertDTMF("1", "70", "10");');
     65
     66
    4667                }
    4768            }

  • trunk/Source/WebCore/ChangeLog

    r168924 r168966  
     12014-05-16  Kiran  <kiran.guduru@samsung.com>
     2
     3        RTCDtmfSender default values need to be updated.
     4        https://bugs.webkit.org/show_bug.cgi?id=132952
     5
     6        Reviewed by Eric Carlson.
     7
     8        The default ToneDuration and ToneGap values are modified in the updated spec.
     9        So these values need to be updated.
     10
     11        Test: fast/mediastream/RTCPeerConnection-dtmf.html.
     12
     13        * Modules/mediastream/RTCDTMFSender.cpp:
     14
    1152014-05-15  Daniel Bates  <dabates@apple.com>
    216

  • trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp

    r159769 r168966  
    3939namespace WebCore {
    4040
    41 static const long minToneDurationMs = 70;
     41static const long minToneDurationMs = 40;
    4242static const long defaultToneDurationMs = 100;
    4343static const long maxToneDurationMs = 6000;
    44 static const long minInterToneGapMs = 50;
    45 static const long defaultInterToneGapMs = 50;
     44static const long minInterToneGapMs = 30;
     45static const long defaultInterToneGapMs = 70;
    4646
    4747PassRefPtr<RTCDTMFSender> RTCDTMFSender::create(ScriptExecutionContext* context, RTCPeerConnectionHandler* peerConnectionHandler, PassRefPtr<MediaStreamTrack> prpTrack, ExceptionCode& ec)
Note: See TracChangeset for help on using the changeset viewer.