Changeset 169314 in webkit

Timestamp:

May 24, 2014 8:12:27 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Remove one of the CSSProperty constructor
​https://bugs.webkit.org/show_bug.cgi?id=131094

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-05-24
Reviewed by Darin Adler.

Remove one of the CSSProperty constructor, because it is obsolete.

• css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty): Deleted.

• css/StyleProperties.h:

(WebCore::StyleProperties::PropertyReference::toCSSProperty):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSProperty.h (modified) (1 diff)
• css/StyleProperties.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-24  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
+
+        Remove one of the CSSProperty constructor
+        https://bugs.webkit.org/show_bug.cgi?id=131094
+
+        Reviewed by Darin Adler.
+
+        Remove one of the CSSProperty constructor, because it is obsolete.
+
+        * css/CSSProperty.h:
+        (WebCore::CSSProperty::CSSProperty): Deleted.
+        * css/StyleProperties.h:
+        (WebCore::StyleProperties::PropertyReference::toCSSProperty):
+
 2014-05-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/css/CSSProperty.h

@@ -58 +58 @@
     CSSProperty(CSSPropertyID propertyID, PassRefPtr<CSSValue> value, bool important = false, bool isSetFromShorthand = false, int indexInShorthandsVector = 0, bool implicit = false)
         : m_metadata(propertyID, isSetFromShorthand, indexInShorthandsVector, important, implicit, isInheritedProperty(propertyID))
-        , m_value(value)
-    {
-    }
-
-    // FIXME: Remove this.
-    CSSProperty(StylePropertyMetadata metadata, CSSValue* value)
-        : m_metadata(metadata)
         , m_value(value)
     {

trunk/Source/WebCore/css/StyleProperties.h

@@ -76 +76 @@
 
         // FIXME: Remove this.
-        CSSProperty toCSSProperty() const { return CSSProperty(propertyMetadata(), const_cast<CSSValue*>(propertyValue())); }
+        CSSProperty toCSSProperty() const { return CSSProperty(id(), const_cast<CSSValue*>(propertyValue()), isImportant(), propertyMetadata().m_isSetFromShorthand, propertyMetadata().m_indexInShorthandsVector, isImplicit()); }
         const StylePropertyMetadata& propertyMetadata() const;