Changeset 169427 in webkit


Ignore:
Timestamp:
May 28, 2014 11:31:28 AM (10 years ago)
Author:
Chris Fleizach
Message:

AX: WebKit does not recognize ARIA 1.1 tables
https://bugs.webkit.org/show_bug.cgi?id=133163

Reviewed by Darin Adler.

The AXObjectCache code that determines which object to create based on the role needs to be token fallback aware.

Test: accessibility/table-fallback-roles-expose-element-attributes.html

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

Location:
trunk
Files:
2 added
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r169425 r169427  
     12014-05-27  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: WebKit does not recognize ARIA 1.1 tables
     4        https://bugs.webkit.org/show_bug.cgi?id=133163
     5
     6        Reviewed by Darin Adler.
     7
     8        The AXObjectCache code that determines which object to create based on the role needs to be token fallback aware.
     9
     10        Test: accessibility/table-fallback-roles-expose-element-attributes.html
     11
     12        * accessibility/AXObjectCache.cpp:
     13        (WebCore::nodeHasRole):
     14
    1152014-05-28  Radu Stavila  <stavila@adobe.com>
    216
  • trunk/Source/WebCore/accessibility/AXObjectCache.cpp

    r166649 r169427  
    255255        return false;
    256256
    257     return equalIgnoringCase(toElement(node)->fastGetAttribute(roleAttr), role);
     257    auto& roleValue = toElement(node)->fastGetAttribute(roleAttr);
     258    if (role.isNull())
     259        return roleValue.isEmpty();
     260    if (roleValue.isEmpty())
     261        return false;
     262
     263    return SpaceSplitString(roleValue, true).contains(role);
    258264}
    259265
Note: See TracChangeset for help on using the changeset viewer.