Changeset 169558 in webkit

Timestamp:

Jun 2, 2014 11:51:26 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Add a verbose flag to binding tests
​https://bugs.webkit.org/show_bug.cgi?id=122303

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-06-02
Reviewed by Csaba Osztrogonác.

This patch will:

• Add a verbose keyword argument to the BindingsTests constructor,
• Add --no-verbose option to the run-bindigs-test.

Verbose mode, which is on by default, prints positive results to stdout as before.
When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.

Original patch from Matthew Hanson <​matthew_hanson@apple.com>

• Scripts/run-bindings-tests:

(main):

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.init):
(BindingsTests.detect_changes):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-bindings-tests (modified) (2 diffs)
• Scripts/webkitpy/bindings/main.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
+
+        Add a verbose flag to binding tests
+        https://bugs.webkit.org/show_bug.cgi?id=122303
+
+        Reviewed by Csaba Osztrogonác.
+
+        This patch will:
+        - Add a verbose keyword argument to the BindingsTests constructor,
+        - Add --no-verbose option to the run-bindigs-test.
+        Verbose mode, which is on by default, prints positive results to stdout as before.
+        When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
+
+        Original patch from Matthew Hanson <matthew_hanson@apple.com>
+
+        * Scripts/run-bindings-tests:
+        (main):
+        * Scripts/webkitpy/bindings/main.py:
+        (BindingsTests.__init__):
+        (BindingsTests.detect_changes):
+
 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/Scripts/run-bindings-tests

@@ -41 +41 @@
     """
     reset_results = "--reset-results" in argv
+    verbose = not "--no-verbose" in argv
 
     generators = [
@@ -50 +51 @@
     from webkitpy.bindings.main import BindingsTests
 
-    return BindingsTests(reset_results, generators, executive.Executive()).main()
+    return BindingsTests(reset_results, generators, executive.Executive(), verbose).main()
 
 

trunk/Tools/Scripts/webkitpy/bindings/main.py

@@ -35 +35 @@
 class BindingsTests:
 
-    def __init__(self, reset_results, generators, executive):
+    def __init__(self, reset_results, generators, executive, verbose):
         self.reset_results = reset_results
         self.generators = generators
         self.executive = executive
+        self.verbose = verbose
 
     def generate_from_idl(self, generator, idl_file, output_directory, supplemental_dependency_file):
@@ -113 +114 @@
                 print output
                 changes_found = True
-            else:
+            elif self.verbose:
                 print 'PASS: (%s) %s' % (generator, output_file)
         return changes_found