Changeset 169635 in webkit

Timestamp:

Jun 5, 2014 7:22:26 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r169570.
​https://bugs.webkit.org/show_bug.cgi?id=133565

It breaks Baidu (Requested by benjaminp on #webkit).

Reverted changeset:

"[iOS] Start ignoring common bogus viewport parameters"
​https://bugs.webkit.org/show_bug.cgi?id=133466
​http://trac.webkit.org/changeset/169570

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ViewportArguments.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-05  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r169570.
+        https://bugs.webkit.org/show_bug.cgi?id=133565
+
+        It breaks Baidu (Requested by benjaminp on #webkit).
+
+        Reverted changeset:
+
+        "[iOS] Start ignoring common bogus viewport parameters"
+        https://bugs.webkit.org/show_bug.cgi?id=133466
+        http://trac.webkit.org/changeset/169570
+
 2014-06-05  Michael Timbrook  <timbrook@apple.com>
 

trunk/Source/WebCore/dom/ViewportArguments.cpp

@@ -405 +405 @@
 void finalizeViewportArguments(ViewportArguments& arguments, const FloatSize& screenSize)
 {
-    if (arguments.width == ViewportArguments::ValueDeviceWidth && (arguments.zoom == 1 || arguments.minZoom == 1)) {
-        // A large amount of pages are using the viewport width=device-width + scaling parameters incorrectly.
-        // This has become so pervasive that the vast majority of those pages render better without viewport meta tag than with it.
-        // Clearing the width is a workaround for the most common incorrect viewports. :(
-        arguments.width = ViewportArguments::ValueAuto;
-    } else if (arguments.width == ViewportArguments::ValueDeviceWidth)
+    if (arguments.width == ViewportArguments::ValueDeviceWidth)
         arguments.width = screenSize.width();
     else if (arguments.width == ViewportArguments::ValueDeviceHeight)