Changeset 169777 in webkit

Timestamp:

Jun 10, 2014 3:47:02 PM (10 years ago)

Author:

Simon Fraser

Message:

​https://bugs.webkit.org/show_bug.cgi?id=133694

Revert the part of r169733 that caused this test to start failing.

Source/WebCore:

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):

LayoutTests:

• platform/mac/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-06-10  Simon Fraser  <simon.fraser@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=133694
+
+        Revert the part of r169733 that caused this test to start failing.
+
+        * platform/mac/TestExpectations:
+
 2014-06-10  Andy Estes  <aestes@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1386 +1386 @@
 webkit.org/b/133363 media/video-rtl.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/133694 compositing/iframes/become-composited-nested-iframes.html [ Failure ]
-
 # REGRESSION (6/9/2014): Several TextTrackCue tests became very flaky
 webkit.org/b/133686 media/track/w3c/interfaces/TextTrackCue/align.html [ Pass Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-10  Simon Fraser  <simon.fraser@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=133694
+
+        Revert the part of r169733 that caused this test to start failing.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
+
 2014-06-10  Timothy Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -3441 +3441 @@
 void RenderLayerCompositor::notifyIFramesOfCompositingChange()
 {
-    for (Frame* child = m_renderView.frameView().frame().tree().firstChild(); child; child = child->tree().nextSibling()) {
+    Frame& frame = m_renderView.frameView().frame();
+    for (Frame* child = frame.tree().firstChild(); child; child = child->tree().traverseNext(&frame)) {
         if (child->document() && child->document()->ownerElement())
             child->document()->ownerElement()->scheduleSetNeedsStyleRecalc(SyntheticStyleChange);