Changeset 169936 in webkit

Timestamp:

Jun 13, 2014 9:12:27 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore: [ATK] Fix text inside "span" block in "a" block was not accessible.
​https://bugs.webkit.org/show_bug.cgi?id=132349

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role to the list of roles whose objects always expose atk_text interface.

LayoutTests: [ATK] Add test for accessibility of text inside "span" block in "a" block.
​https://bugs.webkit.org/show_bug.cgi?id=132349

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.

• platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
• platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt (added)
• LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-06-13  Jarek Czekalski  <jarekczek@poczta.onet.pl>
+
+        [ATK] Add test for accessibility of text inside "span" block in "a" block.
+        https://bugs.webkit.org/show_bug.cgi?id=132349
+
+        Reviewed by Mario Sanchez Prada.
+
+        * platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
+        * platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.
+
 2014-06-13  Andrzej Badowski  <a.badowski@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-13  Jarek Czekalski  <jarekczek@poczta.onet.pl>
+
+        [ATK] Fix text inside "span" block in "a" block was not accessible.
+        https://bugs.webkit.org/show_bug.cgi?id=132349
+
+        Reviewed by Mario Sanchez Prada.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role
+          to the list of roles whose objects always expose atk_text interface.
+
 2014-06-13  Alberto Garcia  <berto@igalia.com>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

@@ -1124 +1124 @@
 static bool roleIsTextType(AccessibilityRole role)
 {
-    return role == ParagraphRole || role == HeadingRole || role == DivRole || role == CellRole || role == ListItemRole;
+    return role == ParagraphRole || role == HeadingRole || role == DivRole || role == CellRole
+        || role == LinkRole || role == WebCoreLinkRole || role == ListItemRole;
 }