Changeset 170307 in webkit

Timestamp:

Jun 23, 2014 12:00:34 PM (10 years ago)

Author:

Simon Fraser

Message:

CSS clip property should make layers non-opaque
​https://bugs.webkit.org/show_bug.cgi?id=134147

Source/WebCore:
<rdar://problem/17324579>

Reviewed by Tim Horton.

​https://www.fairphone.com has position:fixed elements with clip: rect(...)
but we were making those layers opaque, resulting in garbage pixels
in areas outside the clip rect.

Fix by checking for the clip property in RenderBox::backgroundIsKnownToBeOpaqueInRect().

Test: compositing/contents-opaque/opaque-with-clip.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Tim Horton.

• compositing/contents-opaque/opaque-with-clip-expected.html: Added.
• compositing/contents-opaque/opaque-with-clip.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/contents-opaque/opaque-with-clip-expected.html (added)
• LayoutTests/compositing/contents-opaque/opaque-with-clip.html (added)
• LayoutTests/compositing/geometry/clip-inside-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-06-23  Simon Fraser  <simon.fraser@apple.com>
+
+        CSS clip property should make layers non-opaque
+        https://bugs.webkit.org/show_bug.cgi?id=134147
+
+        Reviewed by Tim Horton.
+
+        * compositing/contents-opaque/opaque-with-clip-expected.html: Added.
+        * compositing/contents-opaque/opaque-with-clip.html: Added.
+
 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt

@@ -13 +13 @@
           (anchor 0.50 0.44)
           (bounds 90.00 80.00)
-          (contentsOpaque 1)
           (drawsContent 1)
           (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 1.00 1.00])

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-23  Simon Fraser  <simon.fraser@apple.com>
+
+        CSS clip property should make layers non-opaque
+        https://bugs.webkit.org/show_bug.cgi?id=134147
+        <rdar://problem/17324579>
+
+        Reviewed by Tim Horton.
+        
+        https://www.fairphone.com has position:fixed elements with clip: rect(...)
+        but we were making those layers opaque, resulting in garbage pixels
+        in areas outside the clip rect.
+        
+        Fix by checking for the clip property in RenderBox::backgroundIsKnownToBeOpaqueInRect().
+
+        Test: compositing/contents-opaque/opaque-with-clip.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
+
 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -1351 +1351 @@
     // FIXME: Check the opaqueness of background images.
 
-    if (hasClipPath())
+    if (hasClip() || hasClipPath())
         return false;