Changeset 170529 in webkit

Timestamp:

Jun 27, 2014 8:51:01 AM (10 years ago)

Author:

Andre Moreira Magalhaes

Message:

Increase priority on SharedTimer source.
​http://bugs.webkit.org/show_bug.cgi?id=134109

While running webkit on a Debian virtual machine I stumbled upon an issue where JS
setTimeout callbacks were not being properly invoked due to machine limitations and the
usage of a low priority on setTimeout timers.

This patch increases the SharedTimer source priority to use the default glib priority which
fixes the issue, making setTimeout JS calls work properly on the test environment.

Reviewed by Gustavo Noronha Silva.

• platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/SharedTimerGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-27  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
+
+        Increase priority on SharedTimer source.
+        http://bugs.webkit.org/show_bug.cgi?id=134109
+
+        While running webkit on a Debian virtual machine I stumbled upon an issue where JS
+        setTimeout callbacks were not being properly invoked due to machine limitations and the
+        usage of a low priority on setTimeout timers.
+
+        This patch increases the SharedTimer source priority to use the default glib priority which
+        fixes the issue, making setTimeout JS calls work properly on the test environment.
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * platform/gtk/SharedTimerGtk.cpp:
+        (WebCore::setSharedTimerFireInterval):
+
 2014-06-27  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/gtk/SharedTimerGtk.cpp

@@ -49 +49 @@
 
     gSharedTimer.scheduleAfterDelay("[WebKit] sharedTimerTimeoutCallback", std::function<void()>(sharedTimerFiredFunction),
-        std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::duration<double>(interval)), GDK_PRIORITY_REDRAW);
+        std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::duration<double>(interval)), G_PRIORITY_DEFAULT);
 }