Changeset 170529 in webkit


Ignore:
Timestamp:
Jun 27, 2014, 8:51:01 AM (11 years ago)
Author:
Andre Moreira Magalhaes
Message:

Increase priority on SharedTimer source.
http://bugs.webkit.org/show_bug.cgi?id=134109

While running webkit on a Debian virtual machine I stumbled upon an issue where JS
setTimeout callbacks were not being properly invoked due to machine limitations and the
usage of a low priority on setTimeout timers.

This patch increases the SharedTimer source priority to use the default glib priority which
fixes the issue, making setTimeout JS calls work properly on the test environment.

Reviewed by Gustavo Noronha Silva.

  • platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r170528 r170529  
     12014-06-27  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
     2
     3        Increase priority on SharedTimer source.
     4        http://bugs.webkit.org/show_bug.cgi?id=134109
     5
     6        While running webkit on a Debian virtual machine I stumbled upon an issue where JS
     7        setTimeout callbacks were not being properly invoked due to machine limitations and the
     8        usage of a low priority on setTimeout timers.
     9
     10        This patch increases the SharedTimer source priority to use the default glib priority which
     11        fixes the issue, making setTimeout JS calls work properly on the test environment.
     12
     13        Reviewed by Gustavo Noronha Silva.
     14
     15        * platform/gtk/SharedTimerGtk.cpp:
     16        (WebCore::setSharedTimerFireInterval):
     17
    1182014-06-27  Zalan Bujtas  <zalan@apple.com>
    219
  • trunk/Source/WebCore/platform/gtk/SharedTimerGtk.cpp

    r166916 r170529  
    4949
    5050    gSharedTimer.scheduleAfterDelay("[WebKit] sharedTimerTimeoutCallback", std::function<void()>(sharedTimerFiredFunction),
    51         std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::duration<double>(interval)), GDK_PRIORITY_REDRAW);
     51        std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::duration<double>(interval)), G_PRIORITY_DEFAULT);
    5252}
    5353
Note: See TracChangeset for help on using the changeset viewer.