Changeset 170805 in webkit

Timestamp:

Jul 4, 2014, 6:55:55 AM (10 years ago)

Author:

Antti Koivisto

Message:

REGRESSION(r159345): Lines are clipped between pages when printing web content from Safari
​https://bugs.webkit.org/show_bug.cgi?id=134633

Source/WebCore:
<rdar://problem/17088936>

Reviewed by Zalan Bujtas.

Test: printing/simple-lines-break.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Disable simple lines if global pagination is enabled.
Printing does not currently use flow threads which we already test for.

LayoutTests:

Reviewed by Zalan Bujtas.

• printing/simple-lines-break-expected.html: Added.
• printing/simple-lines-break.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/printing/simple-lines-break-expected.html (added)
• LayoutTests/printing/simple-lines-break.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/SimpleLineLayout.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-07-04  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION(r159345): Lines are clipped between pages when printing web content from Safari
+        https://bugs.webkit.org/show_bug.cgi?id=134633
+
+        Reviewed by Zalan Bujtas.
+
+        * printing/simple-lines-break-expected.html: Added.
+        * printing/simple-lines-break.html: Added.
+
 2014-07-02  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-07-04  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION(r159345): Lines are clipped between pages when printing web content from Safari
+        https://bugs.webkit.org/show_bug.cgi?id=134633
+        <rdar://problem/17088936>
+
+        Reviewed by Zalan Bujtas.
+
+        Test: printing/simple-lines-break.html
+
+        * rendering/SimpleLineLayout.cpp:
+        (WebCore::SimpleLineLayout::canUseFor):
+        
+            Disable simple lines if global pagination is enabled.
+            Printing does not currently use flow threads which we already test for.
+
 2014-07-04  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/rendering/SimpleLineLayout.cpp

@@ -104 +104 @@
     if (flow.flowThreadState() != RenderObject::NotInsideFlowThread)
         return false;
+    // Printing does pagination without a flow thread.
+    if (flow.document().paginated())
+        return false;
     if (flow.hasOutline())
         return false;