Changeset 171253 in webkit

Timestamp:

Jul 18, 2014 5:21:56 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

_WKActivatedElementInfo.title should fallback to innerText if the link doesn't have title attribute.
​https://bugs.webkit.org/show_bug.cgi?id=135077

When populate InteractionInformationAtPosition's title value, use a link element's innerText if it
doesn't have title attribute.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-07-18
Reviewed by Dan Bernstein.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-18  Yongjun Zhang  <yongjun_zhang@apple.com>
+
+        _WKActivatedElementInfo.title should fallback to innerText if the link doesn't have title attribute.
+        https://bugs.webkit.org/show_bug.cgi?id=135077
+
+        When populate InteractionInformationAtPosition's title value, use a link element's innerText if it
+        doesn't have title attribute.
+
+        Reviewed by Dan Bernstein.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::getPositionInformation):
+
 2014-07-18  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -1865 +1865 @@
                 info.url = [(NSURL *)linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkElement->getAttribute(HTMLNames::hrefAttr))) absoluteString];
             info.title = element->fastGetAttribute(HTMLNames::titleAttr).string();
+            if (linkElement && info.title.isEmpty())
+                info.title = element->innerText();
             if (element->renderer())
                 info.bounds = element->renderer()->absoluteBoundingBoxRect(true);