Changeset 171307 in webkit

Timestamp:

Jul 21, 2014 11:26:45 AM (10 years ago)

Author:

Simon Fraser

Message:

Add helper functions to dump the scrolling state tree from the debugger
​https://bugs.webkit.org/show_bug.cgi?id=135101

Reviewed by Darin Adler.

Add debug-only showScrollingStateTree() functions that take a ScrollingStateTree* and ScrollingStateNode*
for use while debugging.

• page/scrolling/ScrollingStateTree.cpp:

(showScrollingStateTree):

• page/scrolling/ScrollingStateTree.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingStateTree.cpp (modified) (2 diffs)
• page/scrolling/ScrollingStateTree.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-07-21  Simon Fraser  <simon.fraser@apple.com>
+
+        Add helper functions to dump the scrolling state tree from the debugger
+        https://bugs.webkit.org/show_bug.cgi?id=135101
+
+        Reviewed by Darin Adler.
+
+        Add debug-only showScrollingStateTree() functions that take a ScrollingStateTree* and ScrollingStateNode*
+        for use while debugging.
+
+        * page/scrolling/ScrollingStateTree.cpp:
+        (showScrollingStateTree):
+        * page/scrolling/ScrollingStateTree.h:
+
 2014-07-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp

@@ -34 +34 @@
 #include "ScrollingStateOverflowScrollingNode.h"
 #include "ScrollingStateStickyNode.h"
+#include <wtf/Text/CString.h>
 
 namespace WebCore {
@@ -247 +248 @@
 } // namespace WebCore
 
+#ifndef NDEBUG
+void showScrollingStateTree(const WebCore::ScrollingStateTree* tree)
+{
+    if (!tree)
+        return;
+
+    auto rootNode = tree->rootStateNode();
+    if (!rootNode) {
+        fprintf(stderr, "Scrolling state tree %p with no root node\n", tree);
+        return;
+    }
+
+    String output = rootNode->scrollingStateTreeAsText();
+    fprintf(stderr, "%s\n", output.utf8().data());
+}
+
+void showScrollingStateTree(const WebCore::ScrollingStateNode* node)
+{
+    if (!node)
+        return;
+
+    showScrollingStateTree(&node->scrollingStateTree());
+}
+
+#endif
+
 #endif // ENABLE(ASYNC_SCROLLING) || USE(COORDINATED_GRAPHICS)

trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h

@@ -106 +106 @@
 } // namespace WebCore
 
+#ifndef NDEBUG
+void showScrollingStateTree(const WebCore::ScrollingStateTree*);
+void showScrollingStateTree(const WebCore::ScrollingStateNode*);
+#endif
+
 #endif // ENABLE(ASYNC_SCROLLING) || USE(COORDINATED_GRAPHICS)