Changeset 172039 in webkit

Timestamp:

Aug 5, 2014 11:34:57 AM (10 years ago)

Author:

Antti Koivisto

Message:

REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
​https://bugs.webkit.org/show_bug.cgi?id=135603
<rdar://problem/17876385>

Reviewed by Andreas Kling.

• page/FrameView.cpp:

(WebCore::determineLayerFlushThrottleState):

Disable throttling after user has scrolled the page.
This is consistent with the speculative tiling. It also gets enabled on first scroll.

(WebCore::FrameView::setWasScrolledByUser):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-05  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
+        https://bugs.webkit.org/show_bug.cgi?id=135603
+        <rdar://problem/17876385>
+
+        Reviewed by Andreas Kling.
+
+        * page/FrameView.cpp:
+        (WebCore::determineLayerFlushThrottleState):
+        
+            Disable throttling after user has scrolled the page.
+            This is consistent with the speculative tiling. It also gets enabled on first scroll.
+
+        (WebCore::FrameView::setWasScrolledByUser):
+
 2014-08-05  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -2277 +2277 @@
     if (!page.progress().isMainLoadProgressing())
         return 0;
+    // Scrolling during page loading disables throttling.
+    if (page.mainFrame().view()->wasScrolledByUser())
+        return 0;
     // Disable for image documents so large GIF animations don't get throttled during loading.
     auto* document = page.mainFrame().document();
@@ -3567 +3570 @@
         return;
     m_wasScrolledByUser = wasScrolledByUser;
+    updateLayerFlushThrottling();
     adjustTiledBackingCoverage();
 }