Changeset 172053 in webkit

Timestamp:

Aug 5, 2014 1:15:40 PM (10 years ago)

Author:

Antti Koivisto

Message:

REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
​https://bugs.webkit.org/show_bug.cgi?id=135603
<rdar://problem/17876385>

This hit ASSERT(frame().isMainFrame()) in FrameView::updateLayerFlushThrottling
running scrollbars/scrollbar-iframe-click-does-not-blur-content.html and a few other tests.

• page/FrameView.cpp:

(WebCore::FrameView::setWasScrolledByUser): Only invoke updateLayerFlushThrottling for the main frame.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-05  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
+        https://bugs.webkit.org/show_bug.cgi?id=135603
+        <rdar://problem/17876385>
+        
+        This hit ASSERT(frame().isMainFrame()) in FrameView::updateLayerFlushThrottling
+        running scrollbars/scrollbar-iframe-click-does-not-blur-content.html and a few other tests.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setWasScrolledByUser): Only invoke updateLayerFlushThrottling for the main frame.
+
 2014-08-05  Peyton Randolph  <prandolph@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -3570 +3570 @@
         return;
     m_wasScrolledByUser = wasScrolledByUser;
-    updateLayerFlushThrottling();
+    if (frame().isMainFrame())
+        updateLayerFlushThrottling();
     adjustTiledBackingCoverage();
 }