Changeset 172336 in webkit

Timestamp:

Aug 7, 2014 11:57:32 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Fix accidental always true comparison
​https://bugs.webkit.org/show_bug.cgi?id=135741

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-07
Reviewed by Timothy Hatcher.

Remove accidental "!" that would always cause this comparison to succeed.

• UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.updateLayout):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/OverviewTimelineView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Fix accidental always true comparison
+        https://bugs.webkit.org/show_bug.cgi?id=135741
+
+        Reviewed by Timothy Hatcher.
+
+        Remove accidental "!" that would always cause this comparison to succeed.
+
+        * UserInterface/Views/OverviewTimelineView.js:
+        (WebInspector.OverviewTimelineView.prototype.updateLayout):
+
 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js

@@ -106 +106 @@
         }
 
-        if (!this.currentTime !== oldCurrentTime) {
+        if (this.currentTime !== oldCurrentTime) {
             var selectedTreeElement = this.navigationSidebarTreeOutline.selectedTreeElement;
             var selectionWasHidden = selectedTreeElement && selectedTreeElement.hidden;