Changeset 172510 in webkit

Timestamp:

Aug 12, 2014 7:33:03 PM (10 years ago)

Author:

dbates@webkit.org

Message:

BPLATFORM(IOS) always evaluates to false
​https://bugs.webkit.org/show_bug.cgi?id=135843

Reviewed by Geoffrey Garen.

Fix typo in definition of BPLATFORM() and include system header TargetConditionals.h
(when building on an Apple platform) so that BPLATFORM(X) evaluates to true when
building for platform X. In particular, so that BPLATFORM(IOS) evaluates to true when
building for iOS.

As a side effect of this change, the change made in <​http://trac.webkit.org/changeset/167289>
will be honored and iOS will assume a VM page size of 16kB (again) instead of 4kB.

• bmalloc/BPlatform.h:

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/BPlatform.h (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2014-08-12  Daniel Bates  <dabates@apple.com>
+
+        BPLATFORM(IOS) always evaluates to false
+        https://bugs.webkit.org/show_bug.cgi?id=135843
+
+        Reviewed by Geoffrey Garen.
+
+        Fix typo in definition of BPLATFORM() and include system header TargetConditionals.h
+        (when building on an Apple platform) so that BPLATFORM(X) evaluates to true when
+        building for platform X. In particular, so that BPLATFORM(IOS) evaluates to true when
+        building for iOS.
+
+        As a side effect of this change, the change made in <http://trac.webkit.org/changeset/167289>
+        will be honored and iOS will assume a VM page size of 16kB (again) instead of 4kB.
+
+        * bmalloc/BPlatform.h:
+
 2014-08-11  Andy Estes  <aestes@apple.com>
 

trunk/Source/bmalloc/bmalloc/BPlatform.h

@@ -27 +27 @@
 #define BPlatform_h
 
-#define BPLATFORM(PLATFORM) (defined BPLATFORM_##PLATFORM && PLATFORM_##PLATFORM)
+#ifdef __APPLE__
+#include <TargetConditionals.h>
+#endif
+
+#define BPLATFORM(PLATFORM) (defined BPLATFORM_##PLATFORM && BPLATFORM_##PLATFORM)
 
 #if ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) \