Changeset 172597 in webkit

Timestamp:

Aug 14, 2014 11:54:56 AM (10 years ago)

Author:

Antti Koivisto

Message:

[Forms] We should share RenderStyle object for optgroup and option element
​https://bugs.webkit.org/show_bug.cgi?id=88405

Reviewed by Andreas Kling.

We can remove this special case now.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/StyleResolver.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-14  Antti Koivisto  <antti@apple.com>
+
+        [Forms] We should share RenderStyle object for optgroup and option element
+        https://bugs.webkit.org/show_bug.cgi?id=88405
+
+        Reviewed by Andreas Kling.
+
+        We can remove this special case now.
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::canShareStyleWithElement):
+
 2014-08-14  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -629 +629 @@
         return false;
 
-    // FIXME: We should share style for option and optgroup whenever possible.
-    // Before doing so, we need to resolve issues in HTMLSelectElement::recalcListItems
-    // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cgi?id=88405
-    if (isHTMLOptionElement(element) || isHTMLOptGroupElement(element))
-        return false;
-
     bool isControl = element->isFormControlElement();