Changeset 172738 in webkit

Timestamp:

Aug 18, 2014 6:04:37 PM (10 years ago)

Author:

Simon Fraser

Message:

Provide default implementations of all GraphicsLayerClient methods
​https://bugs.webkit.org/show_bug.cgi?id=136054

Reviewed by Tim Horton.
Source/WebCore:

Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
subclasses don't need to provide their own implementations.

• platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::notifyAnimationStarted):
(WebCore::GraphicsLayerClient::notifyFlushRequired):
(WebCore::GraphicsLayerClient::paintContents):

• rendering/RenderLayerCompositor.h:

Source/WebKit2:

Remove overrides which are no longer required.

• WebProcess/WebPage/PageOverlayController.h:
• WebProcess/WebPage/ServicesOverlayController.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/GraphicsLayerClient.h (modified) (1 diff)
• WebCore/rendering/RenderLayerCompositor.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/WebPage/PageOverlayController.h (modified) (1 diff)
• WebKit2/WebProcess/WebPage/ServicesOverlayController.h (modified) (1 diff)
• WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-18  Simon Fraser  <simon.fraser@apple.com>
+
+        Provide default implementations of all GraphicsLayerClient methods
+        https://bugs.webkit.org/show_bug.cgi?id=136054
+
+        Reviewed by Tim Horton.
+
+        Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
+        subclasses don't need to provide their own implementations.
+
+        * platform/graphics/GraphicsLayerClient.h:
+        (WebCore::GraphicsLayerClient::notifyAnimationStarted):
+        (WebCore::GraphicsLayerClient::notifyFlushRequired):
+        (WebCore::GraphicsLayerClient::paintContents):
+        * rendering/RenderLayerCompositor.h:
+
 2014-08-18  Pratik Solanki  <psolanki@apple.com>
 

trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h

@@ -63 +63 @@
     
     // Callback for when hardware-accelerated animation started.
-    virtual void notifyAnimationStarted(const GraphicsLayer*, double time) = 0;
+    virtual void notifyAnimationStarted(const GraphicsLayer*, double /*time*/) { }
 
     // Notification that a layer property changed that requires a subsequent call to flushCompositingState()
     // to appear on the screen.
-    virtual void notifyFlushRequired(const GraphicsLayer*) = 0;
+    virtual void notifyFlushRequired(const GraphicsLayer*) { }
     
     // Notification that this layer requires a flush before the next display refresh.
     virtual void notifyFlushBeforeDisplayRefresh(const GraphicsLayer*) { }
 
-    virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const FloatRect& inClip) = 0;
+    virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const FloatRect& /* inClip */) { }
     virtual void didCommitChangesForLayer(const GraphicsLayer*) const { }
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.h

@@ -306 +306 @@
 
     // GraphicsLayerClient implementation
-    virtual void notifyAnimationStarted(const GraphicsLayer*, double) override { }
     virtual void notifyFlushRequired(const GraphicsLayer*) override;
     virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const FloatRect&) override;

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-08-18  Simon Fraser  <simon.fraser@apple.com>
+
+        Provide default implementations of all GraphicsLayerClient methods
+        https://bugs.webkit.org/show_bug.cgi?id=136054
+
+        Reviewed by Tim Horton.
+        
+        Remove overrides which are no longer required.
+
+        * WebProcess/WebPage/PageOverlayController.h:
+        * WebProcess/WebPage/ServicesOverlayController.h:
+        * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
+
 2014-08-18  Pratik Solanki  <psolanki@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.h

@@ -83 +83 @@
 
     // WebCore::GraphicsLayerClient
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) override { }
     virtual void notifyFlushRequired(const WebCore::GraphicsLayer*) override;
     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& clipRect) override;
     virtual float deviceScaleFactor() const override;
-    virtual void didCommitChangesForLayer(const WebCore::GraphicsLayer*) const override { }
     virtual bool shouldSkipLayerInDump(const WebCore::GraphicsLayer*) const override { return true; }
 

trunk/Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h

@@ -85 +85 @@
 
         // GraphicsLayerClient
-        virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) override { }
         virtual void notifyFlushRequired(const WebCore::GraphicsLayer*) override;
         virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& inClip) override;

trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h

@@ -106 +106 @@
     virtual bool adjustLayerFlushThrottling(WebCore::LayerFlushThrottleState::Flags) override;
 
-    // GraphicsLayerClient
-    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) override { }
-    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*) override { }
-    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& inClip) override { }
-
     void updateScrolledExposedRect();