Changeset 172839 in webkit

Timestamp:

Aug 21, 2014 4:49:12 PM (10 years ago)

Author:

Simon Fraser

Message:

Add a button to enable paint flashing in the web inspector
​https://bugs.webkit.org/show_bug.cgi?id=136133

Reviewed by Tim Hatcher.

Add a button to the right of the layer borders button to turn on paint flashing.
Future patches will actually enable this feature.

• Localizations/en.lproj/localizedStrings.js: Tooltip strings.
• UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
• UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype.get navigationItems):
(WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Images/PaintFlashing.svg (added)
• UserInterface/Views/DOMTreeContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-08-21  Simon Fraser  <simon.fraser@apple.com>
+
+        Add a button to enable paint flashing in the web inspector
+        https://bugs.webkit.org/show_bug.cgi?id=136133
+
+        Reviewed by Tim Hatcher.
+        
+        Add a button to the right of the layer borders button to turn on paint flashing.
+        Future patches will actually enable this feature.
+
+        * Localizations/en.lproj/localizedStrings.js: Tooltip strings.
+        * UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
+        * UserInterface/Views/DOMTreeContentView.js:
+        (WebInspector.DOMTreeContentView):
+        (WebInspector.DOMTreeContentView.prototype.get navigationItems):
+        (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
+
 2014-08-20  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -135 +135 @@
 localizedStrings["Disable Breakpoints"] = "Disable Breakpoints";
 localizedStrings["Disable all breakpoints"] = "Disable all breakpoints";
+localizedStrings["Disable paint flashing"] = "Disable paint flashing";
 localizedStrings["Disable point to inspect mode (%s)"] = "Disable point to inspect mode (%s)";
 localizedStrings["Disabled"] = "Disabled";
@@ -182 +183 @@
 localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";
 localizedStrings["Enable all breakpoints"] = "Enable all breakpoints";
+localizedStrings["Enable paint flashing"] = "Enable paint flashing";
 localizedStrings["Enable point to inspect mode (%s)"] = "Enable point to inspect mode (%s)";
 localizedStrings["Encoded"] = "Encoded";

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js

@@ -43 +43 @@
     this._compositingBordersButtonNavigationItem.enabled = !!PageAgent.getCompositingBordersVisible;
 
+    this._paintFlashingButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("paint-flashing", WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable paint flashing"), "Images/PaintFlashing.svg", 16, 16);
+    this._paintFlashingButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._togglePaintFlashing, this);
+    this._paintFlashingButtonNavigationItem.enabled = true;
+
     WebInspector.showShadowDOMSetting.addEventListener(WebInspector.Setting.Event.Changed, this._showShadowDOMSettingChanged, this);
     this._showsShadowDOMButtonNavigationItem = new WebInspector.ActivateButtonNavigationItem("shows-shadow-DOM", WebInspector.UIString("Show shadow DOM nodes"), WebInspector.UIString("Hide shadow DOM nodes"), shadowDOMImage.src, shadowDOMImage.width, shadowDOMImage.height);
@@ -75 +79 @@
     get navigationItems()
     {
-        return [this._showsShadowDOMButtonNavigationItem, this._compositingBordersButtonNavigationItem];
+        return [this._showsShadowDOMButtonNavigationItem, this._compositingBordersButtonNavigationItem, this._paintFlashingButtonNavigationItem];
     },
 
@@ -415 +419 @@
     },
 
+    _togglePaintFlashing: function(event)
+    {
+        console.assert(PageAgent.setShowPaintRects);
+
+        var activated = !this._paintFlashingButtonNavigationItem.activated;
+        this._paintFlashingButtonNavigationItem.activated = activated;
+        PageAgent.setShowPaintRects(activated);
+    },
+
     _updateCompositingBordersButtonToMatchPageSettings: function()
     {