Changeset 172896 in webkit

Timestamp:

Aug 24, 2014 3:07:29 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Toggle buttons visually broken with GTK+ 3.13.7
​https://bugs.webkit.org/show_bug.cgi?id=136130

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-24
Reviewed by Martin Robinson.

No new tests. Hopefully covered by existing tests, and our tests only
run with GTK+ 3.6 anyway.

• platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RenderThemeGtk3.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-24  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Toggle buttons visually broken with GTK+ 3.13.7
+        https://bugs.webkit.org/show_bug.cgi?id=136130
+
+        Reviewed by Martin Robinson.
+
+        No new tests. Hopefully covered by existing tests, and our tests only
+        run with GTK+ 3.6 anyway.
+
+        * platform/gtk/RenderThemeGtk3.cpp:
+        (WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
+        GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.
+
 2014-08-23  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/platform/gtk/RenderThemeGtk3.cpp

@@ -254 +254 @@
         flags |= GTK_STATE_FLAG_INCONSISTENT;
     else if (theme->isChecked(renderObject))
+#if GTK_CHECK_VERSION(3, 13, 7)
+        flags |= GTK_STATE_FLAG_CHECKED;
+#else
         flags |= GTK_STATE_FLAG_ACTIVE;
+#endif
     if (theme->isPressed(renderObject))
         flags |= GTK_STATE_FLAG_SELECTED;