Changeset 172968 in webkit

Timestamp:

Aug 26, 2014, 11:55:16 AM (11 years ago)

Author:

Simon Fraser

Message:

Crashes in hit testing under WebPage::determinePrimarySnapshottedPlugIn()
​https://bugs.webkit.org/show_bug.cgi?id=136240
rdar://problem/17231462

Reviewed by Darin Adler.

determinePrimarySnapshottedPlugIn() does render tree hit testing, so needs
to ensure that layout is up-to-date.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog ¶

@@ +1 @@
+2014-08-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Crashes in hit testing under WebPage::determinePrimarySnapshottedPlugIn()
+        https://bugs.webkit.org/show_bug.cgi?id=136240
+        rdar://problem/17231462
+
+        Reviewed by Darin Adler.
+        
+        determinePrimarySnapshottedPlugIn() does render tree hit testing, so needs
+        to ensure that layout is up-to-date.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::determinePrimarySnapshottedPlugIn):
+
 2014-08-26  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp ¶

@@ -4554 +4554 @@
     ++m_numberOfPrimarySnapshotDetectionAttempts;
 
+    layoutIfNeeded();
+
     MainFrame& mainFrame = corePage()->mainFrame();
     if (!mainFrame.view())