Changeset 172969 in webkit

Timestamp:

Aug 26, 2014 12:00:29 PM (10 years ago)

Author:

Simon Fraser

Message:

Ensure that layout is up-to-date before hit testing
​https://bugs.webkit.org/show_bug.cgi?id=136242
rdar://problem/17435564

Reviewed by Tim Horton.

Various code paths can call into RenderView::hitTest() but fail to
ensure that layout is up-to-date. This is a conservative change that
fixes the issue for callers of EventHandler::hitTestResultAtPoint(),
including WebPage::acceptsFirstMouse() and WebFrame::hitTest().

This change is not general enough that we can ASSERT(!needsLayout())
in RenderView::hitTest() yet.

• page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/EventHandler.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Ensure that layout is up-to-date before hit testing
+        https://bugs.webkit.org/show_bug.cgi?id=136242
+        rdar://problem/17435564
+
+        Reviewed by Tim Horton.
+        
+        Various code paths can call into RenderView::hitTest() but fail to
+        ensure that layout is up-to-date. This is a conservative change that
+        fixes the issue for callers of EventHandler::hitTestResultAtPoint(),
+        including WebPage::acceptsFirstMouse() and WebFrame::hitTest().
+        
+        This change is not general enough that we can ASSERT(!needsLayout())
+        in RenderView::hitTest() yet.
+        
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::hitTestResultAtPoint):
+
 2014-08-26  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -1136 +1136 @@
         return result;
 
+    m_frame.document()->updateLayout();
+    
     // hitTestResultAtPoint is specifically used to hitTest into all frames, thus it always allows child frame content.
     HitTestRequest request(hitType | HitTestRequest::AllowChildFrameContent);