Changeset 173162 in webkit


Ignore:
Timestamp:
Sep 1, 2014 2:15:21 PM (10 years ago)
Author:
Brian Burg
Message:

Provide column numbers to DTrace willExecute/didExecute probes
​https://bugs.webkit.org/show_bug.cgi?id=136434

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Provide the columnNumber and update stubs for !HAVE(DTRACE).

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

  • runtime/Tracing.d:
  • runtime/Tracing.h:

Tools:

Create a directory for DTrace scripts. Add an example script that
shows how to use static probes provided by JavaScriptCore's profiler.

  • Scripts/dtrace/jsc-trace-profiler-events.d: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r173155 r173162  
     12014-09-01  Brian J. Burg  <burg@cs.washington.edu>
     2
     3        Provide column numbers to DTrace willExecute/didExecute probes
     4        https://bugs.webkit.org/show_bug.cgi?id=136434
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Provide the columnNumber and update stubs for !HAVE(DTRACE).
     9
     10        * profiler/ProfileGenerator.cpp:
     11        (JSC::ProfileGenerator::willExecute):
     12        (JSC::ProfileGenerator::didExecute):
     13        * runtime/Tracing.d:
     14        * runtime/Tracing.h:
     15
    1162014-09-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    217

  • trunk/Source/JavaScriptCore/profiler/ProfileGenerator.cpp

    r163844 r173162  
    112112        CString name = callIdentifier.functionName().utf8();
    113113        CString url = callIdentifier.url().utf8();
    114         JAVASCRIPTCORE_PROFILE_WILL_EXECUTE(m_profileGroup, const_cast<char*>(name.data()), const_cast<char*>(url.data()), callIdentifier.lineNumber());
     114        JAVASCRIPTCORE_PROFILE_WILL_EXECUTE(m_profileGroup, const_cast<char*>(name.data()), const_cast<char*>(url.data()), callIdentifier.lineNumber(), callIdentifier.columnNumber());
    115115    }
    116116
    … …  
    127127        CString name = callIdentifier.functionName().utf8();
    128128        CString url = callIdentifier.url().utf8();
    129         JAVASCRIPTCORE_PROFILE_DID_EXECUTE(m_profileGroup, const_cast<char*>(name.data()), const_cast<char*>(url.data()), callIdentifier.lineNumber());
     129        JAVASCRIPTCORE_PROFILE_DID_EXECUTE(m_profileGroup, const_cast<char*>(name.data()), const_cast<char*>(url.data()), callIdentifier.lineNumber(), callIdentifier.columnNumber());
    130130    }
    131131

  • trunk/Source/JavaScriptCore/runtime/Tracing.d

    r52082 r173162  
    2929    probe gc__marked();
    3030    probe gc__end();
    31    
    32     probe profile__will_execute(int, char*, char*, int);
    33     probe profile__did_execute(int, char*, char*, int);
     31
     32    probe profile__will_execute(int, char*, char*, int, int);
     33    probe profile__did_execute(int, char*, char*, int, int);
    3434};
    3535

  • trunk/Source/JavaScriptCore/runtime/Tracing.h

    r95901 r173162  
    4040#define JAVASCRIPTCORE_GC_MARKED_ENABLED() 0
    4141
    42 #define JAVASCRIPTCORE_PROFILE_WILL_EXECUTE(arg0, arg1, arg2, arg3)
     42#define JAVASCRIPTCORE_PROFILE_WILL_EXECUTE(arg0, arg1, arg2, arg3, arg4)
    4343#define JAVASCRIPTCORE_PROFILE_WILL_EXECUTE_ENABLED() 0
    4444
    45 #define JAVASCRIPTCORE_PROFILE_DID_EXECUTE(arg0, arg1, arg2, arg3)
     45#define JAVASCRIPTCORE_PROFILE_DID_EXECUTE(arg0, arg1, arg2, arg3, arg4)
    4646#define JAVASCRIPTCORE_PROFILE_DID_EXECUTE_ENABLED() 0
    4747

  • trunk/Tools/ChangeLog

    r173159 r173162  
     12014-09-01  Brian J. Burg  <burg@cs.washington.edu>
     2
     3        Provide column numbers to DTrace willExecute/didExecute probes
     4        https://bugs.webkit.org/show_bug.cgi?id=136434
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Create a directory for DTrace scripts. Add an example script that
     9        shows how to use static probes provided by JavaScriptCore's profiler.
     10
     11        * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
     12
    1132014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    214
Note: See TracChangeset for help on using the changeset viewer.