Changeset 173179 in webkit

Timestamp:

Sep 2, 2014 10:01:35 AM (10 years ago)

Author:

Dániel Bátyai

Message:

[ARM] MacroAssembler generating incorrect code on ARM32 Traditional
​https://bugs.webkit.org/show_bug.cgi?id=136429

Reviewed by Csaba Osztrogonác.

Changed test32 to use tst to check if reg is zero, instead of cmp.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::test32):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerARM.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-09-02  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
+
+        [ARM] MacroAssembler generating incorrect code on ARM32 Traditional
+        https://bugs.webkit.org/show_bug.cgi?id=136429
+
+        Reviewed by Csaba Osztrogonác.
+
+        Changed test32 to use tst to check if reg is zero, instead of cmp.
+
+        * assembler/MacroAssemblerARM.h:
+        (JSC::MacroAssemblerARM::test32):
+
 2014-09-02  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h

@@ -943 +943 @@
     {
         if (mask.m_value == -1)
-            m_assembler.cmp(0, reg);
+            m_assembler.tst(reg, reg);
         else
             m_assembler.tst(reg, m_assembler.getImm(mask.m_value, ARMRegisters::S0));