Changeset 173220 in webkit
- Timestamp:
- Sep 3, 2014 1:18:36 PM (10 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 deleted
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r173218 r173220 1 2014-09-03 Anders Carlsson <andersca@apple.com> 2 3 Get rid of DOMImplementationFront 4 https://bugs.webkit.org/show_bug.cgi?id=136495 5 6 Reviewed by Andreas Kling. 7 8 DOMImplementationFront was used in a workaround for a GCC bug, and since we're building with clang 9 on Mac this is no longer an issue. 10 11 * WebCore.xcodeproj/project.pbxproj: 12 * bindings/objc/DOMImplementationFront.cpp: Removed. 13 * bindings/objc/DOMImplementationFront.h: Removed. 14 Remove files. 15 16 * bindings/objc/DOMUtility.mm: 17 (JSC::createDOMWrapper): 18 Remove call to implementationFront. 19 20 * bindings/scripts/CodeGeneratorObjC.pm: 21 (GetImplClassName): 22 Remove DOMImplementation special case 23 24 (AddIncludesForType): 25 Ditto. 26 27 (GenerateHeader): 28 Use the class header name in the #import in the internal header. 29 30 (GenerateImplementation): 31 Remove DOMImplementation special case. 32 1 33 2014-09-03 Brent Fulgham <bfulgham@apple.com> 2 34 -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r173198 r173220 3291 3291 93C4A4161629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93C4A4141629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm */; }; 3292 3292 93C4F6EB1108F9A50099D0DB /* AccessibilityScrollbar.h in Headers */ = {isa = PBXBuildFile; fileRef = 93C4F6E91108F9A50099D0DB /* AccessibilityScrollbar.h */; }; 3293 93C841F809CE855C00DFF5E5 /* DOMImplementationFront.h in Headers */ = {isa = PBXBuildFile; fileRef = 93C841F709CE855C00DFF5E5 /* DOMImplementationFront.h */; };3294 93C841FF09CE858300DFF5E5 /* DOMImplementationFront.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93C841FE09CE858300DFF5E5 /* DOMImplementationFront.cpp */; };3295 3293 93CCF0270AF6C52900018E89 /* NavigationAction.h in Headers */ = {isa = PBXBuildFile; fileRef = 93CCF0260AF6C52900018E89 /* NavigationAction.h */; settings = {ATTRIBUTES = (Private, ); }; }; 3296 3294 93CCF0600AF6CA7600018E89 /* NavigationAction.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93CCF05F0AF6CA7600018E89 /* NavigationAction.cpp */; }; … … 10412 10410 93C4A4141629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingTreeFrameScrollingNodeMac.mm; sourceTree = "<group>"; }; 10413 10411 93C4F6E91108F9A50099D0DB /* AccessibilityScrollbar.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityScrollbar.h; sourceTree = "<group>"; }; 10414 93C841F709CE855C00DFF5E5 /* DOMImplementationFront.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMImplementationFront.h; sourceTree = "<group>"; };10415 93C841FE09CE858300DFF5E5 /* DOMImplementationFront.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMImplementationFront.cpp; sourceTree = "<group>"; };10416 10412 93CA4C9909DF93FA00DF8677 /* html.css */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = html.css; sourceTree = "<group>"; }; 10417 10413 93CA4C9A09DF93FA00DF8677 /* make-css-file-arrays.pl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.perl; path = "make-css-file-arrays.pl"; sourceTree = "<group>"; }; … … 16760 16756 isa = PBXGroup; 16761 16757 children = ( 16762 93C841FE09CE858300DFF5E5 /* DOMImplementationFront.cpp */,16763 93C841F709CE855C00DFF5E5 /* DOMImplementationFront.h */,16764 16758 856C8AE20A912649005C687B /* DOMObject.h */, 16765 16759 856C8AE30A912649005C687B /* DOMObject.mm */, … … 23947 23941 85E711D00AC5D5350053270F /* DOMHTMLUListElementInternal.h in Headers */, 23948 23942 A8185F3B09765766005826D9 /* DOMImplementation.h in Headers */, 23949 93C841F809CE855C00DFF5E5 /* DOMImplementationFront.h in Headers */,23950 23943 BC1A37B9097C715F0019F3D8 /* DOMInternal.h in Headers */, 23951 23944 85FF315A0AAFBFCB00374F38 /* DOMKeyboardEvent.h in Headers */, … … 27490 27483 85BA4D180AA688680088052D /* DOMHTMLUListElement.mm in Sources */, 27491 27484 A8185F3E09765766005826D9 /* DOMImplementation.cpp in Sources */, 27492 93C841FF09CE858300DFF5E5 /* DOMImplementationFront.cpp in Sources */,27493 27485 BC1A37BA097C715F0019F3D8 /* DOMInternal.mm in Sources */, 27494 27486 85FF315B0AAFBFCB00374F38 /* DOMKeyboardEvent.mm in Sources */, -
trunk/Source/WebCore/bindings/objc/DOMUtility.mm
r165676 r173220 33 33 #import "DOMCSSValueInternal.h" 34 34 #import "DOMCounterInternal.h" 35 #import "DOMDOMImplementationInternal.h" 35 36 #import "DOMEventInternal.h" 36 37 #import "DOMHTMLCollectionInternal.h" 37 #import "DOMImplementationFront.h"38 38 #import "DOMInternal.h" 39 39 #import "DOMMediaListInternal.h" … … 76 76 #import "WebScriptObjectPrivate.h" 77 77 #import "runtime_root.h" 78 79 // FIXME: Couldn't get an include of "DOMDOMImplementationInternal.h" to work here.80 DOMImplementation *kit(WebCore::DOMImplementationFront*);81 78 82 79 // This file makes use of both the ObjC DOM API and the C++ DOM API, so we need to be careful about what … … 128 125 129 126 if (object->inherits(WebCore::JSDOMImplementation::info())) 130 return kit( implementationFront(static_cast<WebCore::JSDOMImplementation*>(object)));127 return kit(&static_cast<WebCore::JSDOMImplementation*>(object)->impl()); 131 128 132 129 return nil; -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
r173176 r173220 421 421 my $name = shift; 422 422 423 return "DOMImplementationFront" if $name eq "DOMImplementation";424 423 return "DOMWindow" if $name eq "AbstractView"; 425 424 return $name; … … 678 677 $implIncludes{"DOMAbstractViewInternal.h"} = 1; 679 678 $implIncludes{"DOMWindow.h"} = 1; 680 return;681 }682 683 if ($type eq "DOMImplementation") {684 $implIncludes{"DOMDOMImplementationInternal.h"} = 1;685 $implIncludes{"DOMImplementationFront.h"} = 1;686 679 return; 687 680 } … … 1102 1095 } 1103 1096 1104 push(@internalHeaderContent, "\n#import <WebCore/$className.h>\n\n"); 1097 my $classHeaderName = GetClassHeaderName($className); 1098 push(@internalHeaderContent, "\n#import <WebCore/$classHeaderName.h>\n\n"); 1105 1099 1106 1100 if ($interfaceName eq "Node") { … … 1304 1298 # Special cases 1305 1299 my @customGetterContent = (); 1306 if ($attributeTypeSansPtr eq "DOMImplementation") { 1307 # FIXME: We have to special case DOMImplementation until DOMImplementationFront is removed 1308 $getterContentHead = "kit(implementationFront(IMPL"; 1309 $getterContentTail .= ")"; 1310 } elsif ($attributeName =~ /(\w+)DisplayString$/) { 1300 if ($attributeName =~ /(\w+)DisplayString$/) { 1311 1301 my $attributeToDisplay = $1; 1312 1302 $getterContentHead = "WebCore::displayString(IMPL->$attributeToDisplay(), core(self)";
Note: See TracChangeset
for help on using the changeset viewer.