Changeset 173294 in webkit


Ignore:
Timestamp:
Sep 4, 2014 5:23:08 PM (10 years ago)
Author:
Simon Fraser
Message:

CSS filter on a compositing layer should not cause unncessary backing store allocation
https://bugs.webkit.org/show_bug.cgi?id=136557

Reviewed by Dean Jackson.

Source/WebCore:

Remove the style.hasFilter() check from hasBoxDecorations(), since filters aren't
a box decoration. This allows creation of simple container layers with composited filters.

Test: compositing/backing/filter-no-backing.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

Dump the layer tree on some layer configs with filters.

  • compositing/backing/filter-no-backing-expected.txt: Added.
  • compositing/backing/filter-no-backing.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r173293 r173294  
     12014-09-04  Simon Fraser  <simon.fraser@apple.com>
     2
     3        CSS filter on a compositing layer should not cause unncessary backing store allocation
     4        https://bugs.webkit.org/show_bug.cgi?id=136557
     5
     6        Reviewed by Dean Jackson.
     7       
     8        Dump the layer tree on some layer configs with filters.
     9       
     10        * compositing/backing/filter-no-backing-expected.txt: Added.
     11        * compositing/backing/filter-no-backing.html: Added.
     12
    1132014-09-04  Simon Fraser  <simon.fraser@apple.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r173293 r173294  
     12014-09-04  Simon Fraser  <simon.fraser@apple.com>
     2
     3        CSS filter on a compositing layer should not cause unncessary backing store allocation
     4        https://bugs.webkit.org/show_bug.cgi?id=136557
     5
     6        Reviewed by Dean Jackson.
     7       
     8        Remove the style.hasFilter() check from hasBoxDecorations(), since filters aren't
     9        a box decoration. This allows creation of simple container layers with composited filters.
     10
     11        Test: compositing/backing/filter-no-backing.html
     12
     13        * rendering/RenderLayer.cpp:
     14        (WebCore::RenderLayer::calculateClipRects):
     15
    1162014-09-04  Simon Fraser  <simon.fraser@apple.com>
    217
  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r173293 r173294  
    62476247}
    62486248
    6249 // FIXME: use RenderObject::hasBoxDecorations(). And why hasBorderRadius() and filter?
     6249// FIXME: use RenderObject::hasBoxDecorations(). And why hasBorderRadius()?
    62506250static bool hasBoxDecorations(const RenderStyle& style)
    62516251{
    6252     return style.hasBorder() || style.hasBorderRadius() || style.hasOutline() || style.hasAppearance() || style.boxShadow() || style.hasFilter();
     6252    return style.hasBorder() || style.hasBorderRadius() || style.hasOutline() || style.hasAppearance() || style.boxShadow();
    62536253}
    62546254
Note: See TracChangeset for help on using the changeset viewer.