Changeset 173350 in webkit

Timestamp:

Sep 5, 2014 9:58:35 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Use WTFString::split(char) in more places
​https://bugs.webkit.org/show_bug.cgi?id=136543

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-05
Reviewed by Sam Weinig.

Source/WebCore:

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForPath):

• mathml/MathMLMencloseElement.cpp:

(WebCore::MathMLMencloseElement::collectStyleForPresentationAttribute):

• page/PerformanceResourceTiming.cpp:

(WebCore::passesTimingAllowCheck):

• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):

• platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::parseExtensions):

• platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillDataObjectFromDropData):

• platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::loadResponseHeaders):

• platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::loadIndex):

Source/WebKit2:

• Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::PluginVersion::parse):

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::initInspectorServer):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::isTransparentSilverlightBackgroundValue):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorDOMAgent.cpp (modified) (1 diff)
• WebCore/mathml/MathMLMencloseElement.cpp (modified) (1 diff)
• WebCore/page/PerformanceResourceTiming.cpp (modified) (1 diff)
• WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp (modified) (1 diff)
• WebCore/platform/graphics/opengl/GLPlatformContext.cpp (modified) (1 diff)
• WebCore/platform/gtk/PasteboardHelper.cpp (modified) (1 diff)
• WebCore/platform/network/curl/CurlCacheEntry.cpp (modified) (1 diff)
• WebCore/platform/network/curl/CurlCacheManager.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm (modified) (1 diff)
• WebKit2/UIProcess/gtk/WebContextGtk.cpp (modified) (1 diff)
• WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-09-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Use WTFString::split(char) in more places
+        https://bugs.webkit.org/show_bug.cgi?id=136543
+
+        Reviewed by Sam Weinig.
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::nodeForPath):
+        * mathml/MathMLMencloseElement.cpp:
+        (WebCore::MathMLMencloseElement::collectStyleForPresentationAttribute):
+        * page/PerformanceResourceTiming.cpp:
+        (WebCore::passesTimingAllowCheck):
+        * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
+        (WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):
+        * platform/graphics/opengl/GLPlatformContext.cpp:
+        (WebCore::parseExtensions):
+        * platform/gtk/PasteboardHelper.cpp:
+        (WebCore::PasteboardHelper::fillDataObjectFromDropData):
+        * platform/network/curl/CurlCacheEntry.cpp:
+        (WebCore::CurlCacheEntry::loadResponseHeaders):
+        * platform/network/curl/CurlCacheManager.cpp:
+        (WebCore::CurlCacheManager::loadIndex):
+
 2014-09-05  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp

@@ -1937 +1937 @@
     Node* node = m_document.get();
     Vector<String> pathTokens;
-    path.split(",", false, pathTokens);
+    path.split(',', false, pathTokens);
     if (!pathTokens.size())
         return 0;

trunk/Source/WebCore/mathml/MathMLMencloseElement.cpp

@@ -79 +79 @@
         return;
     if (name == MathMLNames::notationAttr) {
-        val.split(" ", m_notationValues);
+        val.split(' ', m_notationValues);
         size_t notationValueSize = m_notationValues.size();
         for (size_t i = 0; i < notationValueSize; i++) {

trunk/Source/WebCore/page/PerformanceResourceTiming.cpp

@@ -68 +68 @@
     const String& securityOrigin = requestingDocument->securityOrigin()->toString();
     Vector<String> timingAllowOrigins;
-    timingAllowOriginString.split(" ", timingAllowOrigins);
+    timingAllowOriginString.split(' ', timingAllowOrigins);
     for (size_t i = 0; i < timingAllowOrigins.size(); ++i)
         if (timingAllowOrigins[i] == securityOrigin)

trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp

@@ -216 +216 @@
     String extensionsString = getExtensions();
     Vector<String> availableExtensions;
-    extensionsString.split(" ", availableExtensions);
+    extensionsString.split(' ', availableExtensions);
     for (size_t i = 0; i < availableExtensions.size(); ++i)
         m_availableExtensions.add(availableExtensions[i]);

trunk/Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp

@@ -78 +78 @@
 {
     Vector<String> extNames;
-    extensionsString.split(" ", extNames);
+    extensionsString.split(' ', extNames);
     HashSet<String> splitExtNames;
     unsigned size = extNames.size();

trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp

@@ -248 +248 @@
         String urlWithLabel(selectionDataToUTF8String(data));
         Vector<String> pieces;
-        urlWithLabel.split("\n", pieces);
+        urlWithLabel.split('\n', pieces);
 
         // Give preference to text/uri-list here, as it can hold more

trunk/Source/WebCore/platform/network/curl/CurlCacheEntry.cpp

@@ -154 +154 @@
     String headerContent = String(buffer.data(), buffer.size());
     Vector<String> headerFields;
-    headerContent.split("\n", headerFields);
+    headerContent.split('\n', headerFields);
 
     Vector<String>::const_iterator it = headerFields.begin();

trunk/Source/WebCore/platform/network/curl/CurlCacheManager.cpp

@@ -130 +130 @@
     String headerContent = String(buffer.data(), buffer.size());
     Vector<String> indexURLs;
-    headerContent.split("\n", indexURLs);
+    headerContent.split('\n', indexURLs);
     buffer.clear();
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-09-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Use WTFString::split(char) in more places
+        https://bugs.webkit.org/show_bug.cgi?id=136543
+
+        Reviewed by Sam Weinig.
+
+        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
+        (WebKit::PluginVersion::parse):
+        * UIProcess/gtk/WebContextGtk.cpp:
+        (WebKit::initInspectorServer):
+        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+        (WebKit::isTransparentSilverlightBackgroundValue):
+
 2014-09-05  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm

@@ -444 +444 @@
 
     Vector<String> versionStringComponents;
-    versionString.split(".", versionStringComponents);
+    versionString.split('.', versionStringComponents);
     for (size_t i = 0; i < versionStringComponents.size(); ++i) {
         bool successfullyParsed = false;

trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp

@@ -62 +62 @@
 
         Vector<String> result;
-        serverAddress.split(":", result);
+        serverAddress.split(':', result);
 
         if (result.size() == 2) {

trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp

@@ -561 +561 @@
     } else if (lowercaseBackgroundValue.startsWith("sc#")) {
         Vector<String> components;
-        lowercaseBackgroundValue.substring(3).split(",", components);
+        lowercaseBackgroundValue.substring(3).split(',', components);
 
         // An ScRGB value with alpha transparency, in the form sc#A,R,G,B.