Changeset 173635 in webkit
- Timestamp:
- Sep 15, 2014 3:52:47 PM (10 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r173634 r173635 1 2014-09-15 Alexey Proskuryakov <ap@apple.com> 2 3 Crash when logging in to optionshouse.com 4 https://bugs.webkit.org/show_bug.cgi?id=136834 5 6 Reviewed by Anders Carlsson. 7 8 No test, because I couldn't make one. I don't have a way to reproduce first-hand. 9 10 * platform/network/cf/SocketStreamHandleCFNet.cpp: 11 (WebCore::SocketStreamHandle::readStreamCallback): 12 (WebCore::SocketStreamHandle::writeStreamCallback): 13 1 14 2014-09-15 Jer Noble <jer.noble@apple.com> 2 15 -
trunk/Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp
r169782 r173635 425 425 SocketStreamHandle* handle = static_cast<SocketStreamHandle*>(clientCallBackInfo); 426 426 ASSERT_UNUSED(stream, stream == handle->m_readStream.get()); 427 // Workaround for <rdar://problem/17727073>. Keeping this below the assertion as we'd like better steps to reproduce this. 428 if (!handle->m_readStream) 429 return; 430 427 431 #if PLATFORM(WIN) 428 432 callOnMainThreadAndWait([&] { … … 439 443 SocketStreamHandle* handle = static_cast<SocketStreamHandle*>(clientCallBackInfo); 440 444 ASSERT_UNUSED(stream, stream == handle->m_writeStream.get()); 445 // This wasn't seen happening in practice, yet it seems like it could, due to symmetry with read stream callback. 446 if (!handle->m_writeStream) 447 return; 448 441 449 #if PLATFORM(WIN) 442 450 callOnMainThreadAndWait([&] {
Note: See TracChangeset
for help on using the changeset viewer.