Changeset 173640 in webkit

Timestamp:

Sep 15, 2014 5:41:36 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: mouse drifts away from resizer when resizing docked inspector
​https://bugs.webkit.org/show_bug.cgi?id=22263

Patch by Matt Baker <Matt Baker> on 2014-09-15
Reviewed by Joseph Pecoraro.

Modified the docked resizer dragging logic to record the initial mouse down position relative to the
resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
correctly with respect to the resize direction before updating the attached window dimension.

• UserInterface/Base/Main.js:

(WebInspector._dockedResizerMouseDown.dockedResizerDrag):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-09-15  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: mouse drifts away from resizer when resizing docked inspector
+        https://bugs.webkit.org/show_bug.cgi?id=22263
+
+        Reviewed by Joseph Pecoraro.
+
+        Modified the docked resizer dragging logic to record the initial mouse down position relative to the
+        resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
+        correctly with respect to the resize direction before updating the attached window dimension.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector._dockedResizerMouseDown.dockedResizerDrag):
+
 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -1282 +1282 @@
 
     var windowProperty = this._dockSide === "bottom" ? "innerHeight" : "innerWidth";
-    var eventProperty = this._dockSide === "bottom" ? "screenY" : "screenX";
+    var eventScreenProperty = this._dockSide === "bottom" ? "screenY" : "screenX";
+    var eventClientProperty = this._dockSide === "bottom" ? "clientY" : "clientX";
 
     var resizerElement = event.target;
-    var lastScreenPosition = event[eventProperty];
+    var firstClientPosition = event[eventClientProperty];
+    var lastScreenPosition = event[eventScreenProperty];
 
     function dockedResizerDrag(event)
@@ -1292 +1294 @@
             return;
 
-        var position = event[eventProperty];
-        var dimension = window[windowProperty] - (position - lastScreenPosition);
+        var position = event[eventScreenProperty];
+        var delta = position - lastScreenPosition;
+        var clientPosition = event[eventClientProperty];
+
+        lastScreenPosition = position;
+
+        // If delta is positive the docked Inspector size is decreasing, in which case the cursor client position
+        // with respect to the target cannot be less than the first mouse down position within the target.
+        if (delta > 0 && clientPosition < firstClientPosition)
+            return;
+
+        // If delta is negative the docked Inspector size is increasing, in which case the cursor client position
+        // with respect to the target cannot be greater than the first mouse down position within the target.
+        if (delta < 0 && clientPosition > firstClientPosition)
+            return;
+
+        var dimension = Math.max(0, window[windowProperty] - delta);
 
         if (this._dockSide === "bottom")
@@ -1299 +1316 @@
         else
             InspectorFrontendHost.setAttachedWindowWidth(dimension);
-
-        lastScreenPosition = position;
     }