Changeset 173664 in webkit

Timestamp:

Sep 16, 2014 11:09:21 AM (10 years ago)

Author:

jer.noble@apple.com

Message:

Videos with controls enabled never receive 'dragstart' events.
​https://bugs.webkit.org/show_bug.cgi?id=136837

Reviewed by Eric Carlson.

Fixes a crash regression introduced by r173631. Node::contains() has an interesting property of returning false
if this is NULL. Rather than depending on this behavior, explicitly NULL-check state.source and bail early.

• page/DragController.cpp:

(WebCore::DragController::startDrag):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DragController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-09-16  Jer Noble  <jer.noble@apple.com>
+
+        Videos with controls enabled never receive 'dragstart' events.
+        https://bugs.webkit.org/show_bug.cgi?id=136837
+
+        Reviewed by Eric Carlson.
+
+        Fixes a crash regression introduced by r173631. Node::contains() has an interesting property of returning false
+        if `this` is NULL. Rather than depending on this behavior, explicitly NULL-check state.source and bail early.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::startDrag):
+
 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebCore/page/DragController.cpp

@@ -718 +718 @@
 bool DragController::startDrag(Frame& src, const DragState& state, DragOperation srcOp, const PlatformMouseEvent& dragEvent, const IntPoint& dragOrigin)
 {
-    if (!src.view() || !src.contentRenderer())
+    if (!src.view() || !src.contentRenderer() || !state.source)
         return false;