Changeset 173737 in webkit

Timestamp:

Sep 18, 2014, 3:31:43 PM (11 years ago)

Author:

Simon Fraser

Message:

Avoid divide by zero when we get an empty rect while snapshotting a node
​https://bugs.webkit.org/show_bug.cgi?id=136932
rdar://problem/18383473

Reviewed by Dean Jackson.

renderer()->paintingRootRect() can return an empty rect for some inline configurations,
for example an <a> containing a floated <span>

When this occurs, avoid a divide by zero and return a null snapshot image.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotNode):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-09-18  Simon Fraser  <simon.fraser@apple.com>
+
+        Avoid divide by zero when we get an empty rect while snapshotting a node
+        https://bugs.webkit.org/show_bug.cgi?id=136932
+        rdar://problem/18383473
+
+        Reviewed by Dean Jackson.
+        
+        renderer()->paintingRootRect() can return an empty rect for some inline configurations,
+        for example an <a> containing a floated <span>
+        
+        When this occurs, avoid a divide by zero and return a null snapshot image.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::snapshotNode):
+
 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -1713 +1713 @@
     LayoutRect topLevelRect;
     IntRect snapshotRect = snappedIntRect(node.renderer()->paintingRootRect(topLevelRect));
+    if (snapshotRect.isEmpty())
+        return nullptr;
 
     double scaleFactor = 1;