Changeset 173997 in webkit

Timestamp:

Sep 25, 2014 11:24:03 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=136854

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-25
Reviewed by Gyuyoung Kim.

'Escape' key should exit fullscreen first and then should be used to stop page load.

• MiniBrowser/efl/main.c:

(on_key_down):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
+
+        [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=136854
+
+        Reviewed by Gyuyoung Kim.
+
+        'Escape' key should exit fullscreen first and then should be used to stop page load.
+
+        * MiniBrowser/efl/main.c:
+        (on_key_down):
+
 2014-09-25  Dean Jackson  <dino@apple.com>
 

trunk/Tools/MiniBrowser/efl/main.c

@@ -546 +546 @@
         info("Reload (F5 or Ctrl+r) was pressed, reloading...");
         ewk_view_reload(ewk_view);
-    } else if (!strcmp(ev->key, "F6") || !strcmp(ev->key, "Escape")) {
-        info("Stop (F6 or Escape) was pressed, stop loading.");
+    } else if (!strcmp(ev->key, "F6")) {
+        info("Stop (F6) was pressed, stop loading.");
         ewk_view_stop(ewk_view);
     } else if (!strcmp(ev->key, "F7")) {
@@ -579 +579 @@
         else if (elm_win_fullscreen_get(window->elm_window))
             ewk_view_fullscreen_exit(ewk_view);
+        else
+            ewk_view_stop(ewk_view);
     } else if (ctrlPressed && (!strcmp(ev->key, "minus") || !strcmp(ev->key, "KP_Subtract"))) {
         if (zoom_level_set(ewk_view, window->current_zoom_level - 1))