Changeset 174058 in webkit


Ignore:
Timestamp:
Sep 29, 2014 4:54:52 AM (10 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137209

Reviewed by Philippe Normand.

Source/WebCore:

IntPointGtk is unused and IntRectGtk is only required by GTK+2 and
only used when building with GTK+2 in GtkInputMethodFilter.cpp
that can be easily replaced.

  • PlatformGTK.cmake:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/gtk/IntPointGtk.cpp: Removed.
  • platform/graphics/gtk/IntRectGtk.cpp: Removed.
  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect):

Tools:

  • TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp

from the WebCore test sources.

Location:
trunk
Files:
2 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r174057 r174058  
     12014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
     4        https://bugs.webkit.org/show_bug.cgi?id=137209
     5
     6        Reviewed by Philippe Normand.
     7
     8        IntPointGtk is unused and IntRectGtk is only required by GTK+2 and
     9        only used when building with GTK+2 in GtkInputMethodFilter.cpp
     10        that can be easily replaced.
     11
     12        * PlatformGTK.cmake:
     13        * platform/graphics/IntPoint.h:
     14        * platform/graphics/IntRect.h:
     15        * platform/graphics/gtk/IntPointGtk.cpp: Removed.
     16        * platform/graphics/gtk/IntRectGtk.cpp: Removed.
     17        * platform/gtk/GtkInputMethodFilter.cpp:
     18        (WebCore::GtkInputMethodFilter::setCursorRect):
     19
    1202014-09-02  Sergio Villar Senin  <svillar@igalia.com>
    221

  • trunk/Source/WebCore/PlatformGTK.cmake

    r174055 r174058  
    213213    platform/graphics/gtk/ImageBufferGtk.cpp
    214214    platform/graphics/gtk/ImageGtk.cpp
    215     platform/graphics/gtk/IntPointGtk.cpp
    216     platform/graphics/gtk/IntRectGtk.cpp
    217215
    218216    platform/gtk/ClipboardUtilitiesGtk.cpp

  • trunk/Source/WebCore/platform/graphics/IntPoint.h

    r172862 r174058  
    4848typedef struct tagPOINT POINT;
    4949typedef struct tagPOINTS POINTS;
    50 #elif PLATFORM(GTK)
    51 typedef struct _GdkPoint GdkPoint;
    5250#endif
    5351
    … …  
    121119    IntPoint(const POINTS&);
    122120    operator POINTS() const;
    123 #elif PLATFORM(GTK)
    124     IntPoint(const GdkPoint&);
    125     operator GdkPoint() const;
    126121#elif PLATFORM(EFL)
    127122    explicit IntPoint(const Evas_Point&);

  • trunk/Source/WebCore/platform/graphics/IntRect.h

    r172862 r174058  
    5050#if PLATFORM(WIN)
    5151typedef struct tagRECT RECT;
    52 #elif PLATFORM(GTK)
    53 #ifdef GTK_API_VERSION_2
    54 typedef struct _GdkRectangle GdkRectangle;
    55 #endif
    5652#endif
    5753
    … …  
    172168    IntRect(const RECT&);
    173169    operator RECT() const;
    174 #elif PLATFORM(GTK)
    175 #ifdef GTK_API_VERSION_2
    176     IntRect(const GdkRectangle&);
    177     operator GdkRectangle() const;
    178 #endif
    179170#elif PLATFORM(EFL)
    180171    explicit IntRect(const Eina_Rectangle&);

  • trunk/Source/WebCore/platform/gtk/GtkInputMethodFilter.cpp

    r163797 r174058  
    9191    translatedRect.move(allocation.x, allocation.y);
    9292
    93     GdkRectangle gdkCursorRect = cursorRect;
     93    GdkRectangle gdkCursorRect = { cursorRect.x(), cursorRect.y(), cursorRect.width(), cursorRect.height() };
    9494    gtk_im_context_set_cursor_location(m_context.get(), &gdkCursorRect);
    9595}

  • trunk/Tools/ChangeLog

    r174051 r174058  
     12014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
     4        https://bugs.webkit.org/show_bug.cgi?id=137209
     5
     6        Reviewed by Philippe Normand.
     7
     8        * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
     9        from the WebCore test sources.
     10
    1112014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
    212

  • trunk/Tools/TestWebKitAPI/PlatformGTK.cmake

    r173720 r174058  
    117117    ${WEBCORE_DIR}/platform/graphics/IntSize.cpp
    118118    ${WEBCORE_DIR}/platform/graphics/cairo/IntRectCairo.cpp
    119     ${WEBCORE_DIR}/platform/graphics/gtk/IntRectGtk.cpp
    120119    ${WEBCORE_DIR}/platform/gtk/GtkInputMethodFilter.cpp
    121120    ${TESTWEBKITAPI_DIR}/Tests/WebCore/gtk/InputMethodFilter.cpp
Note: See TracChangeset for help on using the changeset viewer.