Changeset 174772 in webkit

Timestamp:

Oct 16, 2014 9:01:19 AM (10 years ago)

Author:

ddkilzer@apple.com

Message:

Display legal text when uploading a patch with a new bug

• js/attachment.js:

(setContentTypeDisabledState): Make this work on the Enter Bug
page so that the "Submit Bug" button changes to
"Agree and Submit Bug" when the "patch" checkbox is checked, and
it changes back to "Submit Bug" when unchecked.

• template/en/custom/attachment/createformcontents.html.tmpl:

Include the attachment/patchlegalese.html.tmpl template when
returning the page so that it will be shown when the "patch"
checkbox is checked. Set the 'product' variable from the CGI
variable of the same name.

• template/en/custom/attachment/patchlegalese.html.tmpl: Add the

'expert_fields' class to the <tr> element so that it gets
shown/hidden when the Show/Hide Advanced Fields links are
clicked.

Location:

trunk/Websites/bugs.webkit.org

Files:

• js/attachment.js (modified) (1 diff)
• template/en/custom/attachment/createformcontents.html.tmpl (modified) (1 diff)
• template/en/custom/attachment/patchlegalese.html.tmpl (modified) (1 diff)

trunk/Websites/bugs.webkit.org/js/attachment.js

@@ -56 +56 @@
     if (isdisabled) {
         document.getElementById('legal').style.display = "table-row";
-        document.getElementById('create').value = "Agree and Submit";
+        var createButton = document.getElementById('create');
+        if (createButton && createButton.value == "Submit")
+            createButton.value = "Agree and Submit";
+        else {
+            var commitButton = document.getElementById('commit');
+            if (commitButton && commitButton.value == "Submit Bug")
+                commitButton.value = "Agree and Submit Bug";
+        }
     } else {
-        document.getElementById('create').value = "Submit";
+        var createButton = document.getElementById('create');
+        if (createButton && createButton.value == "Agree and Submit")
+            createButton.value = "Submit";
+        else {
+            var commitButton = document.getElementById('commit');
+            if (commitButton && commitButton.value == "Agree and Submit Bug")
+                commitButton.value = "Submit Bug";
+        }
         document.getElementById('legal').style.display = "none";
     }

trunk/Websites/bugs.webkit.org/template/en/custom/attachment/createformcontents.html.tmpl

@@ -92 +92 @@
   </td>
 </tr>
+[%# if WEBKIT_CHANGES %]
+[% USE CGI %]
+[% cgi_product = CGI.param('product') %]
+[% PROCESS attachment/patchlegalese.html.tmpl product = cgi_product %]
+[%# endif // WEBKIT_CHANGES %]
 
 [% BLOCK content_types %]

trunk/Websites/bugs.webkit.org/template/en/custom/attachment/patchlegalese.html.tmpl

@@ -25 +25 @@
 [%# if WEBKIT_CHANGES %]
 [% IF (product == "WebKit" || product == "Security") %] 
-    <tr id="legal" style="display: none;">
+    <tr id="legal" class="expert_fields" style="display: none;">
       <th>Legal:</th>
       <td>