Changeset 175506 in webkit

Timestamp:

Nov 3, 2014, 6:43:44 PM (11 years ago)

Author:

Simon Fraser

Message:

Non-fast scrollable region overlay offsets the overlay by topContentInset
​https://bugs.webkit.org/show_bug.cgi?id=138344

Reviewed Tim Horton.

Offset the region by topContentInset, and make it not green.

• page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DebugPageOverlays.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-03  Simon Fraser  <simon.fraser@apple.com>
+
+        Non-fast scrollable region overlay offsets the overlay by topContentInset
+        https://bugs.webkit.org/show_bug.cgi?id=138344
+
+        Reviewed Tim Horton.
+        
+        Offset the region by topContentInset, and make it not green.
+
+        * page/DebugPageOverlays.cpp:
+        (WebCore::NonFastScrollableRegionOverlay::updateRegion):
+
 2014-11-03  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/page/DebugPageOverlays.cpp

@@ -115 +115 @@
 private:
     explicit NonFastScrollableRegionOverlay(MainFrame& frame)
-        : RegionOverlay(frame, Color(0.0f, 0.5f, 0.0f, 0.4f))
+        : RegionOverlay(frame, Color(1.0f, 0.5f, 0.0f, 0.4f))
     {
     }
@@ -130 +130 @@
             *region = scrollingCoordinator->computeNonFastScrollableRegion(&m_frame, IntPoint());
     }
+
+    // computeNonFastScrollableRegion() applies topContentInset.
+    region->translate(IntSize(0, -m_frame.view()->topContentInset()));
 
     bool regionChanged = !m_region || !(*m_region == *region);