Changeset 175513 in webkit


Ignore:
Timestamp:
Nov 3, 2014 11:22:18 PM (9 years ago)
Author:
Chris Dumez
Message:

Allow implicit conversion from Ref<T> to T&
​https://bugs.webkit.org/show_bug.cgi?id=138331

Reviewed by Andreas Kling.

Source/WebCore:

Remove unnecessary calls to Ref<T>::get() now that a Ref<T> can be
converted implicitly to a T&.

No new tests, no behavior change.

Source/WebKit2:

Remove unnecessary calls to Ref<T>::get() now that a Ref<T> can be
converted implicitly to a T&.

Source/WTF:

Allow implicit conversion from Ref<T> to T& to reduce the amount of
Ref<>::get() calls in the code and increase readability. Unlike for
RefPtr, doing this for Ref should not be error prone.

  • wtf/Ref.h:

(WTF::Ref::operator T&):
(WTF::Ref::operator const T&):

  • wtf/RunLoop.cpp:

(WTF::RunLoop::Holder::runLoop):

Location:
trunk/Source
Files:
43 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r175424 r175513  
     12014-11-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Allow implicit conversion from Ref<T> to T&
     4        https://bugs.webkit.org/show_bug.cgi?id=138331
     5
     6        Reviewed by Andreas Kling.
     7
     8        Allow implicit conversion from Ref<T> to T& to reduce the amount of
     9        Ref<>::get() calls in the code and increase readability. Unlike for
     10        RefPtr, doing this for Ref should not be error prone.
     11
     12        * wtf/Ref.h:
     13        (WTF::Ref::operator T&):
     14        (WTF::Ref::operator const T&):
     15        * wtf/RunLoop.cpp:
     16        (WTF::RunLoop::Holder::runLoop):
     17
    1182014-10-31  Jeffrey Pfau  <jpfau@apple.com>
    219

  • trunk/Source/WTF/wtf/Ref.h

    r173801 r175513  
    6262    T& get() { return *m_ptr; }
    6363
     64    operator T&() { return *m_ptr; }
     65    operator const T&() const { return *m_ptr; }
     66
    6467    template<typename U> PassRef<T> replace(PassRef<U>) WARN_UNUSED_RETURN;
    6568

  • trunk/Source/WTF/wtf/RunLoop.cpp

    r170774 r175513  
    4242    }
    4343
    44     RunLoop& runLoop() { return m_runLoop.get(); }
     44    RunLoop& runLoop() { return m_runLoop; }
    4545
    4646private:

  • trunk/Source/WebCore/ChangeLog

    r175506 r175513  
     12014-11-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Allow implicit conversion from Ref<T> to T&
     4        https://bugs.webkit.org/show_bug.cgi?id=138331
     5
     6        Reviewed by Andreas Kling.
     7
     8        Remove unnecessary calls to Ref<T>::get() now that a Ref<T> can be
     9        converted implicitly to a T&.
     10
     11        No new tests, no behavior change.
     12
    1132014-11-03  Simon Fraser  <simon.fraser@apple.com>
    214

  • trunk/Source/WebCore/bindings/js/JSDOMWindowShell.h

    r167963 r175513  
    6363        }
    6464
    65         DOMWrapperWorld& world() { return m_world.get(); }
     65        DOMWrapperWorld& world() { return m_world; }
    6666
    6767    protected:

  • trunk/Source/WebCore/css/CSSStyleSheet.h

    r174332 r175513  
    114114    void reattachChildRuleCSSOMWrappers();
    115115
    116     StyleSheetContents& contents() { return m_contents.get(); }
     116    StyleSheetContents& contents() { return m_contents; }
    117117
    118118    void detachFromDocument() { m_ownerNode = nullptr; }

  • trunk/Source/WebCore/css/CSSToStyleMap.cpp

    r175487 r175513  
    551551            image.setImage(styleImage(imageProperty, current.get()));
    552552        else if (is<CSSBorderImageSliceValue>(current.get()))
    553             mapNinePieceImageSlice(current.get(), image);
     553            mapNinePieceImageSlice(current, image);
    554554        else if (is<CSSValueList>(current.get())) {
    555555            CSSValueList& slashList = downcast<CSSValueList>(current.get());
    … …  
    567567        } else if (is<CSSPrimitiveValue>(current.get())) {
    568568            // Set the appropriate rules for stretch/round/repeat of the slices.
    569             mapNinePieceImageRepeat(current.get(), image);
     569            mapNinePieceImageRepeat(current, image);
    570570        }
    571571    }

  • trunk/Source/WebCore/css/CSSValue.h

    r174300 r175513  
    248248inline bool compareCSSValue(const Ref<CSSValueType>& first, const Ref<CSSValueType>& second)
    249249{
    250     return first.get().equals(second.get());
     250    return first.get().equals(second);
    251251}
    252252

  • trunk/Source/WebCore/css/CSSValueList.cpp

    r172536 r175513  
    9797        ASSERT_NOT_REACHED();
    9898    }
    99     for (unsigned i = 0, size = m_values.size(); i < size; ++i)
    100         newList->append(m_values[i].get());
     99    for (auto& value : m_values)
     100        newList->append(value.get());
    101101    return newList.release();
    102102}
    … …  
    120120    }
    121121
    122     for (unsigned i = 0, size = m_values.size(); i < size; i++) {
     122    for (auto& value : m_values) {
    123123        if (!result.isEmpty())
    124124            result.append(separator);
    125         result.append(m_values[i].get().cssText());
     125        result.append(value.get().cssText());
    126126    }
    127127
    … …  
    138138
    139139    for (unsigned i = 0, size = m_values.size(); i < size; ++i) {
    140         if (!m_values[i].get().equals(other.m_values[i].get()))
     140        if (!m_values[i].get().equals(other.m_values[i]))
    141141            return false;
    142142    }

  • trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp

    r175487 r175513  
    15801580                if (childIndex <= list->size())
    15811581                    list->append(Animation::create());
    1582                 map(styleResolver, list->animation(childIndex), currentValue.get());
     1582                map(styleResolver, list->animation(childIndex), currentValue);
    15831583                ++childIndex;
    15841584            }

  • trunk/Source/WebCore/css/ElementRuleCollector.cpp

    r174069 r175513  
    5353    if (leftToRightDecl.get()->isEmpty())
    5454        leftToRightDecl.get()->setProperty(CSSPropertyDirection, CSSValueLtr);
    55     return leftToRightDecl.get().get();
     55    return leftToRightDecl.get();
    5656}
    5757
    … …  
    6161    if (rightToLeftDecl.get()->isEmpty())
    6262        rightToLeftDecl.get()->setProperty(CSSPropertyDirection, CSSValueRtl);
    63     return rightToLeftDecl.get().get();
     63    return rightToLeftDecl.get();
    6464}
    6565

  • trunk/Source/WebCore/css/StyleResolver.cpp

    r175490 r175513  
    19801980        ++currentNamedGridLine;
    19811981        GridTrackSize trackSize;
    1982         if (!createGridTrackSize(currentValue.get(), trackSize, state))
     1982        if (!createGridTrackSize(currentValue, trackSize, state))
    19831983            return false;
    19841984

  • trunk/Source/WebCore/css/StyleRule.h

    r174536 r175513  
    111111
    112112    const CSSSelectorList& selectorList() const { return m_selectorList; }
    113     const StyleProperties& properties() const { return m_properties.get(); }
     113    const StyleProperties& properties() const { return m_properties; }
    114114    MutableStyleProperties& mutableProperties();
    115115   
    … …  
    146146    ~StyleRuleFontFace();
    147147
    148     const StyleProperties& properties() const { return m_properties.get(); }
     148    const StyleProperties& properties() const { return m_properties; }
    149149    MutableStyleProperties& mutableProperties();
    150150
    … …  
    166166
    167167    const CSSSelector* selector() const { return m_selectorList.first(); }   
    168     const StyleProperties& properties() const { return m_properties.get(); }
     168    const StyleProperties& properties() const { return m_properties; }
    169169    MutableStyleProperties& mutableProperties();
    170170

  • trunk/Source/WebCore/css/WebKitCSSKeyframeRule.h

    r175391 r175513  
    5050    void getKeys(Vector<double>& keys) const   { parseKeyString(m_key, keys); }
    5151   
    52     const StyleProperties& properties() const { return m_properties.get(); }
     52    const StyleProperties& properties() const { return m_properties; }
    5353    MutableStyleProperties& mutableProperties();
    5454   

  • trunk/Source/WebCore/dom/ChildListMutationScope.cpp

    r170774 r175513  
    8686    Ref<Node> child(childRef);
    8787
    88     if (!isAddedNodeInOrder(child.get()))
     88    if (!isAddedNodeInOrder(child))
    8989        enqueueMutationRecord();
    9090
    … …  
    109109    Ref<Node> child(childRef);
    110110
    111     if (!m_addedNodes.isEmpty() || !isRemovedNodeInOrder(child.get()))
     111    if (!m_addedNodes.isEmpty() || !isRemovedNodeInOrder(child))
    112112        enqueueMutationRecord();
    113113
    … …  
    129129    RefPtr<NodeList> addedNodes = StaticNodeList::adopt(m_addedNodes);
    130130    RefPtr<NodeList> removedNodes = StaticNodeList::adopt(m_removedNodes);
    131     RefPtr<MutationRecord> record = MutationRecord::createChildList(m_target.get(), addedNodes.release(), removedNodes.release(), m_previousSibling.release(), m_nextSibling.release());
     131    RefPtr<MutationRecord> record = MutationRecord::createChildList(m_target, addedNodes.release(), removedNodes.release(), m_previousSibling.release(), m_nextSibling.release());
    132132    m_observers->enqueueMutationRecord(record.release());
    133133    m_lastAdded = 0;

  • trunk/Source/WebCore/dom/ChildNodeList.cpp

    r166460 r175513  
    9292            return nullptr;
    9393    }
    94     for (auto& element : childrenOfType<Element>(m_parent.get())) {
     94    for (auto& element : childrenOfType<Element>(m_parent)) {
    9595        if (element.hasID() && element.idForStyleResolution() == name)
    9696            return const_cast<Element*>(&element);

  • trunk/Source/WebCore/dom/ChildNodeList.h

    r166461 r175513  
    4242    virtual ~EmptyNodeList();
    4343
    44     Node& ownerNode() { return m_owner.get(); }
     44    Node& ownerNode() { return m_owner; }
    4545
    4646private:
    … …  
    6666    virtual ~ChildNodeList();
    6767
    68     ContainerNode& ownerNode() { return m_parent.get(); }
     68    ContainerNode& ownerNode() { return m_parent; }
    6969
    7070    void invalidateCache();

  • trunk/Source/WebCore/dom/ContainerNode.cpp

    r175435 r175513  
    116116    if (oldParent->document().hasMutationObserversOfType(MutationObserver::ChildList)) {
    117117        ChildListMutationScope mutation(*oldParent);
    118         for (unsigned i = 0; i < children.size(); ++i)
    119             mutation.willRemoveChild(children[i].get());
     118        for (auto& child : children)
     119            mutation.willRemoveChild(child);
    120120    }
    121121
    … …  
    125125    oldParent->removeDetachedChildren();
    126126
    127     for (unsigned i = 0; i < children.size(); ++i) {
    128         Node& child = children[i].get();
    129 
     127    for (auto& child : children) {
    130128        destroyRenderTreeIfNeeded(child);
    131129
    132130        // FIXME: We need a no mutation event version of adoptNode.
    133         RefPtr<Node> adoptedChild = document().adoptNode(&children[i].get(), ASSERT_NO_EXCEPTION);
     131        RefPtr<Node> adoptedChild = document().adoptNode(&child.get(), ASSERT_NO_EXCEPTION);
    134132        parserAppendChild(adoptedChild.get());
    135133        // FIXME: Together with adoptNode above, the tree scope might get updated recursively twice
    … …  
    300298        treeScope().adoptIfNeeded(&child);
    301299
    302         insertBeforeCommon(next.get(), child);
     300        insertBeforeCommon(next, child);
    303301
    304302        updateTreeAfterInsertion(child);
    … …  
    550548    }
    551549
    552     willRemoveChild(child.get());
     550    willRemoveChild(child);
    553551
    554552    // Mutation events might have moved this child into a different parent.
    … …  
    563561        Node* prev = child->previousSibling();
    564562        Node* next = child->nextSibling();
    565         removeBetween(prev, next, child.get());
    566 
    567         notifyChildRemoved(child.get(), prev, next, ChildChangeSourceAPI);
    568 
    569         ChildNodeRemovalNotifier(*this).notify(child.get());
     563        removeBetween(prev, next, child);
     564
     565        notifyChildRemoved(child, prev, next, ChildChangeSourceAPI);
     566
     567        ChildNodeRemovalNotifier(*this).notify(child);
    570568    }
    571569
    … …  
    664662        childrenChanged(change);
    665663       
    666         for (size_t i = 0; i < removedChildren.size(); ++i)
    667             ChildNodeRemovalNotifier(*this).notify(removedChildren[i].get());
     664        for (auto& removedChild : removedChildren)
     665            ChildNodeRemovalNotifier(*this).notify(removedChild);
    668666    }
    669667

  • trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp

    r174225 r175513  
    168168    SubframeLoadingDisabler disabler(root);
    169169
    170     for (unsigned i = 0; i < frameOwners.size(); ++i) {
    171         auto& owner = frameOwners[i].get();
     170    bool isFirst = true;
     171    for (auto& owner : frameOwners) {
    172172        // Don't need to traverse up the tree for the first owner since no
    173173        // script could have moved it.
    174         if (!i || root.containsIncludingShadowDOM(&owner))
    175             owner.disconnectContentFrame();
     174        if (isFirst || root.containsIncludingShadowDOM(&owner.get()))
     175            owner.get().disconnectContentFrame();
     176        isFirst = false;
    176177    }
    177178}

  • trunk/Source/WebCore/dom/Node.cpp

    r174840 r175513  
    13651365        case DOCUMENT_FRAGMENT_NODE: {
    13661366            Ref<ContainerNode> container(downcast<ContainerNode>(*this));
    1367             ChildListMutationScope mutation(container.get());
     1367            ChildListMutationScope mutation(container);
    13681368            container->removeChildren();
    13691369            if (!text.isEmpty())

  • trunk/Source/WebCore/editing/ApplyStyleCommand.cpp

    r174300 r175513  
    10521052        // The inner loop will go through children on each level
    10531053        // FIXME: we should aggregate inline child elements together so that we don't wrap each child separately.
    1054         for (size_t i = 0; i < currentChildren.size(); ++i) {
    1055             Node& child = currentChildren[i].get();
     1054        for (Ref<Node>& childRef : currentChildren) {
     1055            Node& child = childRef;
    10561056            if (!child.parentNode())
    10571057                continue;

  • trunk/Source/WebCore/editing/EditCommand.h

    r173235 r175513  
    6565
    6666    Frame& frame();
    67     Document& document() { return m_document.get(); }
     67    Document& document() { return m_document; }
    6868    CompositeEditCommand* parent() const { return m_parent; }
    6969    void setStartingSelection(const VisibleSelection&);

  • trunk/Source/WebCore/editing/Editor.cpp

    r174876 r175513  
    12221222                if (autocorrectionWasApplied)
    12231223                    options |= TypingCommand::RetainAutocorrectionIndicator;
    1224                 TypingCommand::insertText(document.get(), text, selection, options, triggeringEvent && triggeringEvent->isComposition() ? TypingCommand::TextCompositionConfirm : TypingCommand::TextCompositionNone);
     1224                TypingCommand::insertText(document, text, selection, options, triggeringEvent && triggeringEvent->isComposition() ? TypingCommand::TextCompositionConfirm : TypingCommand::TextCompositionNone);
    12251225            }
    12261226

  • trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm

    r174676 r175513  
    564564NSAttributedString *HTMLConverter::convert()
    565565{
    566     Node* commonAncestorContainer = _caches->cacheAncestorsOfStartToBeConverted(m_range.get());
     566    Node* commonAncestorContainer = _caches->cacheAncestorsOfStartToBeConverted(m_range);
    567567    ASSERT(commonAncestorContainer);
    568568

  • trunk/Source/WebCore/editing/markup.cpp

    r174300 r175513  
    958958    if (element->ieForbidsInsertHTML()) {
    959959        ec = NOT_SUPPORTED_ERR;
    960         return 0;
     960        return nullptr;
    961961    }
    962962
    … …  
    964964        || element->hasTagName(headTag) || element->hasTagName(styleTag) || element->hasTagName(titleTag)) {
    965965        ec = NOT_SUPPORTED_ERR;
    966         return 0;
     966        return nullptr;
    967967    }
    968968
    969969    RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, element, parserContentPolicy, ec);
    970970    if (!fragment)
    971         return 0;
     971        return nullptr;
    972972
    973973    // We need to pop <html> and <body> elements and remove <head> to
    … …  
    975975    // child of an element.
    976976    auto toRemove = collectElementsToRemoveFromFragment(*fragment);
    977     for (unsigned i = 0; i < toRemove.size(); ++i)
    978         removeElementFromFragmentPreservingChildren(*fragment, toRemove[i].get());
     977    for (auto& element : toRemove)
     978        removeElementFromFragmentPreservingChildren(*fragment, element);
    979979
    980980    return fragment.release();
    … …  
    995995{
    996996    Ref<ContainerNode> containerNode(container);
    997     ChildListMutationScope mutation(containerNode.get());
     997    ChildListMutationScope mutation(containerNode);
    998998
    999999    if (!fragment->firstChild()) {
    … …  
    10191019{
    10201020    Ref<ContainerNode> containerNode(container);
    1021     ChildListMutationScope mutation(containerNode.get());
     1021    ChildListMutationScope mutation(containerNode);
    10221022
    10231023    if (hasOneTextChild(&containerNode.get())) {

  • trunk/Source/WebCore/html/canvas/CanvasGradient.h

    r174410 r175513  
    4848        }
    4949       
    50         Gradient& gradient() { return m_gradient.get(); }
    51         const Gradient& gradient() const { return m_gradient.get(); }
     50        Gradient& gradient() { return m_gradient; }
     51        const Gradient& gradient() const { return m_gradient; }
    5252
    5353        void addColorStop(float value, const String& color, ExceptionCode&);

  • trunk/Source/WebCore/html/canvas/CanvasPattern.h

    r174382 r175513  
    4646    static void parseRepetitionType(const String&, bool& repeatX, bool& repeatY, ExceptionCode&);
    4747
    48     Pattern& pattern() { return m_pattern.get(); }
    49     const Pattern& pattern() const { return m_pattern.get(); }
     48    Pattern& pattern() { return m_pattern; }
     49    const Pattern& pattern() const { return m_pattern; }
    5050
    5151    bool originClean() const { return m_originClean; }

  • trunk/Source/WebCore/loader/DocumentLoader.h

    r175491 r175513  
    104104        WEBCORE_EXPORT ResourceRequest& request();
    105105
    106         CachedResourceLoader& cachedResourceLoader() { return m_cachedResourceLoader.get(); }
     106        CachedResourceLoader& cachedResourceLoader() { return m_cachedResourceLoader; }
    107107
    108108        const SubstituteData& substituteData() const { return m_substituteData; }

  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r175375 r175513  
    32873287    Vector<Ref<DOMWrapperWorld>> worlds;
    32883288    ScriptController::getAllWorlds(worlds);
    3289     for (size_t i = 0; i < worlds.size(); ++i)
    3290         dispatchDidClearWindowObjectInWorld(worlds[i].get());
     3289    for (auto& world : worlds)
     3290        dispatchDidClearWindowObjectInWorld(world);
    32913291}
    32923292
    … …  
    33103310    Vector<Ref<DOMWrapperWorld>> worlds;
    33113311    ScriptController::getAllWorlds(worlds);
    3312     for (size_t i = 0; i < worlds.size(); ++i)
    3313         m_client.dispatchGlobalObjectAvailable(worlds[i].get());
     3312    for (auto& world : worlds)
     3313        m_client.dispatchGlobalObjectAvailable(world);
    33143314}
    33153315

  • trunk/Source/WebCore/page/DOMWindow.cpp

    r174536 r175513  
    255255        windows.uncheckedAppend(*it->key);
    256256
    257     for (unsigned i = 0; i < windows.size(); ++i) {
    258         DOMWindow& window = windows[i].get();
     257    for (Ref<DOMWindow>& windowRef : windows) {
     258        DOMWindow& window = windowRef;
    259259        if (!set.contains(&window))
    260260            continue;
    … …  
    292292    Vector<Ref<DOMWindow>> windows;
    293293    windows.reserveInitialCapacity(set.size());
    294     for (auto it = set.begin(), end = set.end(); it != end; ++it)
    295         windows.uncheckedAppend(*it->key);
    296 
    297     for (unsigned i = 0; i < windows.size(); ++i) {
    298         DOMWindow& window = windows[i].get();
     294    for (auto& keyValue : set)
     295        windows.uncheckedAppend(*keyValue.key);
     296
     297    for (Ref<DOMWindow>& windowRef : windows) {
     298        DOMWindow& window = windowRef;
    299299        if (!set.contains(&window))
    300300            continue;

  • trunk/Source/WebCore/page/animation/AnimationController.cpp

    r174804 r175513  
    517517
    518518    CompositeAnimation& rendererAnimations = m_data->ensureCompositeAnimation(renderer);
    519     auto blendedStyle = rendererAnimations.animate(renderer, oldStyle, newStyleBeforeAnimation.get());
     519    auto blendedStyle = rendererAnimations.animate(renderer, oldStyle, newStyleBeforeAnimation);
    520520
    521521    if (renderer.parent() || newStyleBeforeAnimation->animations() || (oldStyle && oldStyle->animations())) {

  • trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp

    r174657 r175513  
    4949    m_visibleRectIndicatorLayer.get().setBorderColor(Color(255, 0, 0));
    5050
    51     m_layer.get().appendSublayer(m_visibleRectIndicatorLayer.get());
     51    m_layer.get().appendSublayer(m_visibleRectIndicatorLayer);
    5252
    5353    update();

  • trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.h

    r169948 r175513  
    5151    void setPosition(const FloatPoint& position) { m_position = position; }
    5252
    53     PlatformCALayer& layer() { return m_layer.get(); }
     53    PlatformCALayer& layer() { return m_layer; }
    5454
    5555    void setDeviceScaleFactor(float);

  • trunk/Source/WebCore/platform/graphics/ca/TileGrid.h

    r170037 r175513  
    5252    ~TileGrid();
    5353
    54     PlatformCALayer& containerLayer() { return m_containerLayer.get(); }
     54    PlatformCALayer& containerLayer() { return m_containerLayer; }
    5555
    5656    void setScale(float);

  • trunk/Source/WebCore/rendering/ClipPathOperation.h

    r175084 r175513  
    102102    }
    103103
    104     const BasicShape& basicShape() const { return m_shape.get(); }
     104    const BasicShape& basicShape() const { return m_shape; }
    105105    WindRule windRule() const { return m_shape.get().windRule(); }
    106106    const Path pathForReferenceRect(const FloatRect& boundingRect)

  • trunk/Source/WebCore/rendering/RenderNamedFlowThread.h

    r175084 r175513  
    129129    void updateWritingMode();
    130130
    131     WebKitNamedFlow& namedFlow() { return m_namedFlow.get(); }
    132     const WebKitNamedFlow& namedFlow() const { return m_namedFlow.get(); }
     131    WebKitNamedFlow& namedFlow() { return m_namedFlow; }
     132    const WebKitNamedFlow& namedFlow() const { return m_namedFlow; }
    133133
    134134    // Observer flow threads have invalid regions that depend on the state of this thread

  • trunk/Source/WebCore/rendering/style/StyleGeneratedImage.h

    r174836 r175513  
    3939    }
    4040
    41     CSSImageGeneratorValue& imageValue() { return m_imageGeneratorValue.get(); }
     41    CSSImageGeneratorValue& imageValue() { return m_imageGeneratorValue; }
    4242
    4343private:

  • trunk/Source/WebKit2/ChangeLog

    r175503 r175513  
     12014-11-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Allow implicit conversion from Ref<T> to T&
     4        https://bugs.webkit.org/show_bug.cgi?id=138331
     5
     6        Reviewed by Andreas Kling.
     7
     8        Remove unnecessary calls to Ref<T>::get() now that a Ref<T> can be
     9        converted implicitly to a T&.
     10
    1112014-11-03  Simon Fraser  <simon.fraser@apple.com>
    212

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r175476 r175513  
    376376        if (m_userContentController)
    377377            m_process->addWebUserContentControllerProxy(*m_userContentController);
    378         m_process->addVisitedLinkProvider(m_visitedLinkProvider.get());
     378        m_process->addVisitedLinkProvider(m_visitedLinkProvider);
    379379    }
    380380
    … …  
    31703170    if (m_userContentController)
    31713171        m_process->addWebUserContentControllerProxy(*m_userContentController);
    3172     m_process->addVisitedLinkProvider(m_visitedLinkProvider.get());
     3172    m_process->addVisitedLinkProvider(m_visitedLinkProvider);
    31733173}
    31743174

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.h

    r175498 r175513  
    256256#endif
    257257
    258     WebBackForwardList& backForwardList() { return m_backForwardList.get(); }
     258    WebBackForwardList& backForwardList() { return m_backForwardList; }
    259259
    260260    bool addsVisitedLinks() const { return m_addsVisitedLinks; }
    … …  
    739739#endif
    740740
    741     WebProcessProxy& process() { return m_process.get(); }
     741    WebProcessProxy& process() { return m_process; }
    742742    PlatformProcessIdentifier processIdentifier() const;
    743743
    744     WebPreferences& preferences() { return m_preferences.get(); }
     744    WebPreferences& preferences() { return m_preferences; }
    745745    void setPreferences(WebPreferences&);
    746746
    747     WebPageGroup& pageGroup() { return m_pageGroup.get(); }
     747    WebPageGroup& pageGroup() { return m_pageGroup; }
    748748
    749749    bool isValid() const;

  • trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp

    r174803 r175513  
    617617        m_downloadProxyMap = std::make_unique<DownloadProxyMap>(this);
    618618
    619     return m_downloadProxyMap->createDownloadProxy(m_context.get(), request);
     619    return m_downloadProxyMap->createDownloadProxy(m_context, request);
    620620}
    621621

  • trunk/Source/WebKit2/UIProcess/WebProcessProxy.h

    r174803 r175513  
    7979    WebConnection* webConnection() const { return m_webConnection.get(); }
    8080
    81     WebContext& context() { return m_context.get(); }
     81    WebContext& context() { return m_context; }
    8282
    8383    static WebPageProxy* webPage(uint64_t pageID);

  • trunk/Source/WebKit2/WebProcess/UserContent/WebUserContentController.h

    r170891 r175513  
    4242    virtual ~WebUserContentController();
    4343
    44     WebCore::UserContentController& userContentController() { return m_userContentController.get(); }
     44    WebCore::UserContentController& userContentController() { return m_userContentController; }
    4545
    4646    uint64_t identifier() { return m_identifier; }
Note: See TracChangeset for help on using the changeset viewer.