Changeset 175654 in webkit

Timestamp:

Nov 5, 2014 6:16:09 PM (10 years ago)

Author:

Chris Fleizach

Message:

AX: add "alt" as an overriding synonym of "-webkit-alt" (now in the CSS4 spec)
​https://bugs.webkit.org/show_bug.cgi?id=138393

Reviewed by Dean Jackson.

Source/WebCore:

Add official "alt" CSS keyword and map -webkit-alt to that.

Test: platform/mac/accessibility/alt-for-css-content.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSPropertyNames.in:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

• platform/mac/accessibility/alt-for-css-content-expected.txt: Added.
• platform/mac/accessibility/alt-for-css-content.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/accessibility/alt-for-css-content-expected.txt (added)
• LayoutTests/platform/mac/accessibility/alt-for-css-content.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (3 diffs)
• Source/WebCore/css/CSSParser.cpp (modified) (1 diff)
• Source/WebCore/css/CSSPropertyNames.in (modified) (1 diff)
• Source/WebCore/css/StyleResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-11-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: add "alt" as an overriding synonym of "-webkit-alt" (now in the CSS4 spec)
+        https://bugs.webkit.org/show_bug.cgi?id=138393
+
+        Reviewed by Dean Jackson.
+
+        * platform/mac/accessibility/alt-for-css-content-expected.txt: Added.
+        * platform/mac/accessibility/alt-for-css-content.html: Added.
+
 2014-11-05  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: add "alt" as an overriding synonym of "-webkit-alt" (now in the CSS4 spec)
+        https://bugs.webkit.org/show_bug.cgi?id=138393
+
+        Reviewed by Dean Jackson.
+
+        Add official "alt" CSS keyword and map -webkit-alt to that.
+
+        Test: platform/mac/accessibility/alt-for-css-content.html
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::ComputedStyleExtractor::propertyValue):
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseValue):
+        * css/CSSPropertyNames.in:
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::applyProperty):
+
 2014-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -92 +92 @@
 // List of all properties we know how to compute, omitting shorthands.
 static const CSSPropertyID computedProperties[] = {
+    CSSPropertyAlt,
     CSSPropertyBackgroundAttachment,
     CSSPropertyBackgroundBlendMode,
@@ -225 +226 @@
     CSSPropertyZoom,
 
-    CSSPropertyWebkitAlt,
     CSSPropertyWebkitAnimationDelay,
     CSSPropertyWebkitAnimationDirection,
@@ -2841 +2841 @@
         case CSSPropertyWebkitLineBoxContain:
             return createLineBoxContainValue(style->lineBoxContain());
-        case CSSPropertyWebkitAlt:
+        case CSSPropertyAlt:
             return altTextToCSSValue(style.get());
         case CSSPropertyContent:

trunk/Source/WebCore/css/CSSParser.cpp

@@ -1868 +1868 @@
         return parseContent(propId, important);
 
-    case CSSPropertyWebkitAlt: // [ <string> | attr(X) ]
+    case CSSPropertyAlt: // [ <string> | attr(X) ]
         return parseAlt(propId, important);
             

trunk/Source/WebCore/css/CSSPropertyNames.in

@@ -257 +257 @@
 word-wrap [Inherited, NewStyleBuilder=EOverflowWrap, NameForMethods=OverflowWrap]
 z-index
--webkit-alt
+alt
+-webkit-alt = alt
 -webkit-animation
 -webkit-animation-delay

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -2231 +2231 @@
             return;
         }
-    case CSSPropertyWebkitAlt:
+    case CSSPropertyAlt:
         {
             bool didSet = false;