Changeset 175980 in webkit

Timestamp:

Nov 11, 2014, 2:59:28 PM (11 years ago)

Author:

eric.carlson@apple.com

Message:

[iOS] a page with video in optimized fullscreen is visible
​https://bugs.webkit.org/show_bug.cgi?id=138632

Reviewed by Anders Carlsson.

Source/WebCore:

• platform/ios/WebVideoFullscreenInterfaceAVKit.h:

(WebCore::WebVideoFullscreenInterfaceAVKit::mode): Expose fullscreen mode.

Source/WebKit2:

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isPlayingFullscreenOptimizedVideo]): New.

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewVisible): Return true if displaying optimized fullscreen

video.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/API/Cocoa/WKWebView.mm (modified) (2 diffs)
• WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h (modified) (1 diff)
• WebKit2/UIProcess/ios/PageClientImplIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog ¶

@@ +1 @@
+2014-11-11  Eric Carlson  <eric.carlson@apple.com>
+
+        [iOS] a page with video in optimized fullscreen is visible
+        https://bugs.webkit.org/show_bug.cgi?id=138632
+
+        Reviewed by Anders Carlsson.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.h:
+        (WebCore::WebVideoFullscreenInterfaceAVKit::mode): Expose fullscreen mode.
+
 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h ¶

@@ -88 +88 @@
     WEBCORE_EXPORT virtual void invalidate();
     WEBCORE_EXPORT virtual void requestHideAndExitFullscreen();
-    
+
+    HTMLMediaElement::VideoFullscreenMode mode() const { return m_mode; }
+
 protected:
         

trunk/Source/WebKit2/ChangeLog ¶

@@ +1 @@
+2014-11-11  Eric Carlson  <eric.carlson@apple.com>
+
+        [iOS] a page with video in optimized fullscreen is visible
+        https://bugs.webkit.org/show_bug.cgi?id=138632
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _isPlayingFullscreenOptimizedVideo]): New.
+
+        * UIProcess/API/Cocoa/WKWebViewInternal.h:
+        * UIProcess/ios/PageClientImplIOS.mm:
+        (WebKit::PageClientImpl::isViewVisible): Return true if displaying optimized fullscreen
+            video.
+
 2014-11-11  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm ¶

@@ -91 +91 @@
 #import "WKWebViewContentProviderRegistry.h"
 #import "WebPageMessages.h"
+#import "WebVideoFullscreenManagerProxy.h"
 #import <CoreGraphics/CGFloat.h>
 #import <CoreGraphics/CGPDFDocumentPrivate.h>
@@ -237 +238 @@
 {
     return deviceOrientationForUIInterfaceOrientation([[UIApplication sharedApplication] statusBarOrientation]);
+}
+
+- (BOOL)_isPlayingFullscreenOptimizedVideo
+{
+    return _page->videoFullscreenManager() && _page->videoFullscreenManager()->mode() == WebCore::HTMLMediaElement::HTMLMediaElement::VideoFullscreenModeOptimized;
 }
 #endif

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h ¶

@@ -99 +99 @@
 - (void)_didSameDocumentNavigationForMainFrame:(WebKit::SameDocumentNavigationType)navigationType;
 
+- (BOOL)_isPlayingFullscreenOptimizedVideo;
+
 @property (nonatomic, readonly) UIEdgeInsets _computedContentInset;
 #else

trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm ¶

@@ -180 +180 @@
 bool PageClientImpl::isViewVisible()
 {
-    return isViewInWindow() && !m_contentView.isBackground;
+    return isViewInWindow() && (!m_contentView.isBackground || [m_webView _isPlayingFullscreenOptimizedVideo]);
 }