Changeset 176070 in webkit

Timestamp:

Nov 13, 2014 12:53:03 AM (10 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

[EFL] Unexpected crashes in layout test after r175953
​https://bugs.webkit.org/show_bug.cgi?id=138652

Reviewed by Csaba Osztrogonác.

In r175953, it set reusableNodeIndex value with m_partCache's size(). It causes
out of bound index crash because the reusableNodeIndex is Vector object.

No new test. This patch is to fix broken tests related to widgets on EFL port.

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::getThemePartFromCache): Need to set reusableNodeIndex with "size() - 1".

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/efl/RenderThemeEfl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        [EFL] Unexpected crashes in layout test after r175953
+        https://bugs.webkit.org/show_bug.cgi?id=138652
+
+        Reviewed by Csaba Osztrogonác.
+
+        In r175953, it set reusableNodeIndex value with m_partCache's size(). It causes
+        out of bound index crash because the reusableNodeIndex is Vector object.
+
+        No new test. This patch is to fix broken tests related to widgets on EFL port.
+
+        * platform/efl/RenderThemeEfl.cpp:
+        (WebCore::RenderThemeEfl::getThemePartFromCache): Need to set reusableNodeIndex with "size() - 1".
+
 2014-11-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp

@@ -252 +252 @@
     // the last item of the list.
     if (!reusableNodeIndex)
-        reusableNodeIndex = m_partCache.size();
+        reusableNodeIndex = m_partCache.size() - 1;
 
     ThemePartCacheEntry* reusedEntry = m_partCache[reusableNodeIndex].get();