Changeset 176240 in webkit

Timestamp:

Nov 17, 2014, 5:49:33 PM (11 years ago)

Author:

Simon Fraser

Message:

[iOS WK1] Sometimes, missing tiles in -webkit-overflow-scrolling: touch in UIWebViews
​https://bugs.webkit.org/show_bug.cgi?id=138815
rdar://problem/18746203

Reviewed by Tim Horton.

The scroll-velocity-related data members on FrameView, added in r168233, were uninitialized in UIWebViews,
so FrameView::computeCoverageRect() could return garbage results, leading to too much or too little tile coverage.

We still add additional coverage from the new inclusion of a margin area, but, for simplicity, leave that the same
between WK1 and WK2 for now.

• page/FrameView.cpp:

(WebCore::FrameView::FrameView):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-17  Simon Fraser  <simon.fraser@apple.com>
+
+        [iOS WK1] Sometimes, missing tiles in -webkit-overflow-scrolling: touch in UIWebViews
+        https://bugs.webkit.org/show_bug.cgi?id=138815
+        rdar://problem/18746203
+
+        Reviewed by Tim Horton.
+
+        The scroll-velocity-related data members on FrameView, added in r168233, were uninitialized in UIWebViews,
+        so FrameView::computeCoverageRect() could return garbage results, leading to too much or too little tile coverage.
+        
+        We still add additional coverage from the new inclusion of a margin area, but, for simplicity, leave that the same
+        between WK1 and WK2 for now.
+        
+        * page/FrameView.cpp:
+        (WebCore::FrameView::FrameView):
+
 2014-11-17  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -189 +189 @@
     , m_useCustomFixedPositionLayoutRect(false)
     , m_useCustomSizeForResizeEvent(false)
+    , m_horizontalVelocity(0)
+    , m_verticalVelocity(0)
+    , m_scaleChangeRate(0)
+    , m_lastVelocityUpdateTime(0)
 #endif
     , m_hasOverrideViewportSize(false)