Changeset 176384 in webkit

Timestamp:

Nov 20, 2014 12:23:19 AM (9 years ago)

Author:

Antti Koivisto

Message:

REGRESSION (r172854): Web Viewer in FileMaker does not render a Base64 encoded animated-GIF
​https://bugs.webkit.org/show_bug.cgi?id=138807
<rdar://problem/18829540>

Reviewed by Simon Fraser.

Animation gets paused because WebKit thinks the GIF is outside of the view.

• page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):

We need to convert to window coordinates in paintsEntireContents mode too so these functions are consistent.
This matters with some WK1 API clients.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-20  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r172854): Web Viewer in FileMaker does not render a Base64 encoded animated-GIF
+        https://bugs.webkit.org/show_bug.cgi?id=138807
+        <rdar://problem/18829540>
+
+        Reviewed by Simon Fraser.
+
+        Animation gets paused because WebKit thinks the GIF is outside of the view.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::windowClipRect):
+
+        We need to convert to window coordinates in paintsEntireContents mode too so these functions are consistent.
+        This matters with some WK1 API clients.
+
 2014-11-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -3202 +3202 @@
 
     if (paintsEntireContents())
-        return IntRect(IntPoint(), totalContentsSize());
+        return contentsToWindow(IntRect(IntPoint(), totalContentsSize()));
 
     // Set our clip rect to be our contents.