Changeset 176591 in webkit

Timestamp:

Dec 1, 2014 6:48:34 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r176566.
​https://bugs.webkit.org/show_bug.cgi?id=139124

It broke the GTK performance tests. (Requested by clopez on
#webkit).

Reverted changeset:

"[GTK] Use GMainLoopSource in WebKitTestRunner"
​https://bugs.webkit.org/show_bug.cgi?id=138831
​http://trac.webkit.org/changeset/176566

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/TestRunner.h (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp (modified) (1 diff)
• WebKitTestRunner/gtk/TestControllerGtk.cpp (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-12-01  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r176566.
+        https://bugs.webkit.org/show_bug.cgi?id=139124
+
+        It broke the GTK performance tests. (Requested by clopez on
+        #webkit).
+
+        Reverted changeset:
+
+        "[GTK] Use GMainLoopSource in WebKitTestRunner"
+        https://bugs.webkit.org/show_bug.cgi?id=138831
+        http://trac.webkit.org/changeset/176566
+
 2014-11-29  Anders Carlsson  <andersca@apple.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h

@@ -39 +39 @@
 typedef RetainPtr<CFRunLoopTimerRef> PlatformTimerRef;
 #elif PLATFORM(GTK)
-#include <wtf/gobject/GMainLoopSource.h>
-typedef GMainLoopSource PlatformTimerRef;
+typedef unsigned int PlatformTimerRef;
 #elif PLATFORM(EFL)
 typedef Ecore_Timer* PlatformTimerRef;

trunk/Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp

@@ -35 +35 @@
 namespace WTR {
 
+static gboolean waitToDumpWatchdogTimerCallback(gpointer)
+{
+    InjectedBundle::shared().testRunner()->waitToDumpWatchdogTimerFired();
+    return FALSE;
+}
+
 void TestRunner::platformInitialize()
 {
+    m_waitToDumpWatchdogTimer = 0;
 }
 
 void TestRunner::invalidateWaitToDumpWatchdogTimer()
 {
-    m_waitToDumpWatchdogTimer.cancel();
+    if (!m_waitToDumpWatchdogTimer)
+        return;
+    g_source_remove(m_waitToDumpWatchdogTimer);
+    m_waitToDumpWatchdogTimer = 0;
 }
 
 void TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded()
 {
-    if (m_waitToDumpWatchdogTimer.isScheduled())
+    if (m_waitToDumpWatchdogTimer)
         return;
 
-    m_waitToDumpWatchdogTimer.scheduleAfterDelay("[WTR] waitToDumpWatchdogTimerCallback", [this] { waitToDumpWatchdogTimerFired(); },
-        std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::duration<double>(waitToDumpWatchdogTimerInterval)));
+    m_waitToDumpWatchdogTimer = g_timeout_add(waitToDumpWatchdogTimerInterval * 1000,
+                                              waitToDumpWatchdogTimerCallback, 0);
+    g_source_set_name_by_id(m_waitToDumpWatchdogTimer, "[WebKit] waitToDumpWatchdogTimerCallback");
 }
 

trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp

@@ -30 +30 @@
 #include <gtk/gtk.h>
 #include <wtf/Platform.h>
-#include <wtf/gobject/GMainLoopSource.h>
 #include <wtf/gobject/GUniquePtr.h>
 #include <wtf/text/WTFString.h>
@@ -36 +35 @@
 namespace WTR {
 
-static GMainLoopSource timeoutSource;
+static guint gTimeoutSourceId = 0;
+
+static void cancelTimeout()
+{
+    if (!gTimeoutSourceId)
+        return;
+    g_source_remove(gTimeoutSourceId);
+    gTimeoutSourceId = 0;
+}
 
 void TestController::notifyDone()
 {
     gtk_main_quit();
-    timeoutSource.cancel();
+    cancelTimeout();
 }
 
@@ -52 +59 @@
 }
 
+static gboolean timeoutCallback(gpointer)
+{
+    fprintf(stderr, "FAIL: TestControllerRunLoop timed out.\n");
+    gtk_main_quit();
+    return FALSE;
+}
+
 void TestController::platformWillRunTest(const TestInvocation&)
 {
@@ -58 +72 @@
 void TestController::platformRunUntil(bool&, double timeout)
 {
-    timeoutSource.scheduleAfterDelay("[WTR] Test timeout source", [] {
-        fprintf(stderr, "FAIL: TestControllerRunLoop timed out.\n");
-        gtk_main_quit();
-    }, std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::duration<double>(timeout)));
+    cancelTimeout();
+    if (timeout != m_noTimeout) {
+        gTimeoutSourceId = g_timeout_add(timeout * 1000, timeoutCallback, 0);
+        g_source_set_name_by_id(gTimeoutSourceId, "[WebKit] timeoutCallback");
+    }
     gtk_main();
 }